Download & Extend
Issues

image_style_delete_form doesn't take form_state by reference

Posted by neclimdul on June 2, 2012 at 3:51pm
Project:Drupal core
Version:7.x-dev
Component:base system
Category:bug report
Priority:major
Assigned:Unassigned
Status:closed (fixed)
Issue tags:7.15 release notes, Novice, PHP 5.4

Issue Summary

Problem

Image style tests have a failure deleting styles in PHP 5.4. If you have a ubuntu 12.04 LTS system this is pretty easy to reproduce.

Proposed resolution

PHP 5.4 seems to be more strict about taking arguments by reference. Since image_style_delete_form doesn't take $form_state by reference, the style isn't passed to the submit function and the style can't be deleted.

The fix is pretty simple, we just have to add a & in front of $form_state so I'm going to mark this novice.

Remaining tasks

A patch.

User interface changes

Just a bug fix.

API changes

Just a bug fix.

Login or register to post comments

Comments

#1

Posted by brockjo on June 3, 2012 at 7:31pm
Status:active» needs review

Tested this on my test setup: Ubuntu 12.04 LTS, Drupal 8.x, PHP 5.4.3, which results in no errors when deleting style. This should be reviewed though.

AttachmentSizeStatusTest resultOperations
1614292-1-form_state_by_reference.patch607 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 36,695 pass(es).View details

#2

Posted by catch on June 4, 2012 at 1:42am
Issue tags:+needs backport to D7, +PHP 5.4

#3

Posted by skottler on June 4, 2012 at 5:13am
Status:needs review» reviewed & tested by the community

Looks fine to me. Marking RTBC for assignment.

#4

Posted by Dries on June 4, 2012 at 1:50pm
Version:8.x-dev» 7.x-dev

Committed to 8.x. Thanks. Moving to 7.x.

#5

Posted by David_Rothstein on June 4, 2012 at 8:29pm
Version:7.x-dev» 8.x-dev

This and several other issues look like they weren't actually committed/pushed. So, #1 is still RTBC for Drupal 8.

#6

Posted by catch on June 5, 2012 at 8:11am
Version:8.x-dev» 7.x-dev
Status:reviewed & tested by the community» patch (to be ported)

Committed/pushed to 8.x.

#7

Posted by Albert Volkman on June 8, 2012 at 7:25pm
Status:patch (to be ported)» needs review

Easy 7.x backport.

AttachmentSizeStatusTest resultOperations
form_state_by_reference-1614292-7.patch587 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 39,162 pass(es).View details

#8

Posted by Niklas Fiekas on June 8, 2012 at 11:32pm
Status:needs review» reviewed & tested by the community

Looks just like the same thing for 8.x.

#9

Posted by David_Rothstein on June 9, 2012 at 8:48pm
Status:reviewed & tested by the community» fixed
Issue tags:+7.15 release notes

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/8a12512

#10

Posted by Albert Volkman on June 9, 2012 at 10:04pm
Version:7.x-dev» 6.x-dev
Status:fixed» active
Issue tags:-needs backport to D7+needs backport to D6

Should this be backported to 6 as well?

#11

Posted by neclimdul on June 10, 2012 at 3:38am
Version:6.x-dev» 7.x-dev
Status:active» fixed
Issue tags:-needs backport to D6

No, Drupal 6 didn't have this function.

#12

Posted by System Message on June 24, 2012 at 3:41am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here