Wildcard path matches are still now possible i think.

On (success) conditions those might be important in drupal.

Something different are wildcards related to redirects where you need to consider the match for the redirect url.
#663112: wildcards and tokens for path redirects

CommentFileSizeAuthor
#7 multivariate_wildcard_match_1614478_7.patch3.08 KBnonsie
#6 multivariate_wildcard_match_1614478_6.patch2.76 KBpivica
#2 multivariate_wildcard_match_1614478_2.patch2.61 KBnonsie

Comments

pivica’s picture

pivica commented

We have wildcard support for path mutation and path redirection mutation plugins. No support for wildcard in path success plugin - but it should not be a problem to add.

nonsie’s picture

nonsie
she/her
Primary language Estonian
commented
StatusFileSize
new multivariate_wildcard_match_1614478_2.patch2.61 KB

And here's a possible solution how to allow wildcards and <front> in path success plugin

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Active » Needs review

Looks fine, although not tested yet.
There's still no test coverage possible for all this?

nonsie’s picture

nonsie
she/her
Primary language Estonian
commented

No tests so far - still need to be sure if Simpletest supports cookies or not. It seems it's possible now (and it definitely looks doable in D8). Need to spend some time at least attempting to write tests.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

In D8, all the different internal (wildcard) cases will be tested through well defined APIs with unit tests and possibly only one simpletest case can be enough to test if the plugin generally works as a composite.

I can be wrong, but i didn't see tests yet in D8 that test different user sessions in parallel.

pivica’s picture

pivica commented
StatusFileSize
new multivariate_wildcard_match_1614478_6.patch2.76 KB

Hi nonsie,

I tested your patch and it is fine, but while doing this I got an idea why we wouldn't use standard textarea form for entering multiple paths (separated by new line) and then do just simple drupal_match_path() as you proposed (similar like block display is defined per urls). Users should be more use to this UI and also entering multiple success urls is easier.

While testing I also catch one performance bug - in the begging of multivariate_path_sc_boot() when defining current urls if current path does not have alias then drupal_get_path_alias() would return same current system path and we would get double paths in $urls array. This should be fixed now also.

@nonsie can you please check attached patch and do some testing?

nonsie’s picture

nonsie
she/her
Primary language Estonian
commented
StatusFileSize
new multivariate_wildcard_match_1614478_7.patch3.08 KB

I'm all for making the path matching more in line how core is handling it.

Also re-rolled against current dev and fixed some minor formatting issues

pivica’s picture

pivica commented
Status: Needs review » Fixed

Added with 8f7312e commit.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.