Just tried the module out, very nicely done. For some reason, however, the progress bar doesn't slowly move up green. It might be something on my end, however.

CommentFileSizeAuthor
#2 swfupload_progressbar.patch2.42 KBrobloach

Comments

wmostrey’s picture

wmostrey commented
Priority: Normal » Critical

I have the exact same issue. The message remains "Uploading file 1 of 1" and the background remains yellow. The file is not uploaded. Not only that, but I am logged out after this as well.

robloach’s picture

robloach
he/him
commented
Status: Active » Needs review
StatusFileSize
new swfupload_progressbar.patch2.42 KB

The problem stems from the Javascript not knowing where progressbar.png is. Since it's statically set to "modules/swfupload/progressbar.png" in the uploadProgress function of callbacks.js, if your SWFUpload module isn't in that location, the progress bar won't work.

The attached patch uses a Javascript variable instead named "progressbarimage", which is set by Drupal in SWFUpload.module. It will output the correct location where the image is, which will then make the progress bar function correctly.

robloach’s picture

robloach
he/him
commented

Whoops, that patch also includes the Path fix.

robloach’s picture

robloach
he/him
commented
Assigned: Unassigned » robloach
Status: Needs review » Fixed

Committed.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)