[D7] User Track

welcome,

You are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

As installation and usage instructions are quite important for us to review, please take a moment to make your project page follow the tips for a great project page. Also create a README.txt that follows the guidelines for in-project documentation.

An automated review of your project has found some issues with your code; As coding standards make sure projects are coded in a consistent style we please you to have a look at the report and try to fix them. Anyway, note that issues found are possibly false positives and fixing all issues is not a requirement for getting through the application process.
Report: http://ventral.org/pareview/httpgitdrupalorgsandboxashishthakur1614582git

You forgot to rename hook_install and hook_uninstall properly, therefore they wont work...
Also, if you don't do in a hook anything - don't implement it.

This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project.

It appears that there have been multiple project applications opened under your username:
https://drupal.org/node/1511276

As successful completion of the project application process results in the applicant being granted the ´Create Full Projects´ permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as ´closed(duplicate)´, with only the oldest application left open.

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the ´open´ application as a duplicate, and re-open one of the project applications which had been closed.

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

regards

The core tracker module already adds a "track" tab.

The login_history module provides a very similar feature to this module.

One of the 7 principles of the Drupal project is collaboration. Would you consider merging your project into that one and collaborating with it's authors?

Otherwise, it would be great if you could document on the project page what makes this module different and also link to that module so that people can make a good decision about which one to use.

Yeah, you should stat difference of similar modules and consider if can merger together.

User Stats
Provides commonly requested user statistics for themers, IP address tracking and Views integration.

Login Activity
provide important user information about when and from where their user account was used to login to the website.

User IP Log
User IP Log is a simple module that logs the IP address of users on login event to table {uiplog}.

User Stats
Provides commonly requested user statistics for themers, IP address tracking and Views integration

Login History -- stated above

Please provide information why you can't join forces with the existing modules. Creating yet another project for this purpose will only lead to more fragmentation and confused users. Thanks!

Screenshot

Hi a_thakur,

In user_track.module in line 13 you make use of views_api_version() but as you can see in views.module in line 2380 this is not recommended.

In lines 34 and 87 you could consider to use EntityFieldQuery for reach more database abstraction

$query = new EntityFieldQuery;
$entities = $query->entityCondition('entity_type', 'node')
  ->entityCondition('bundle', 'my_type')
  ->fieldCondition('field_foo', 'value', $val)
  ->execute();

It would be useful for users that you added hook_help

/**
  * Implement hook_help()
  */
function yourmodulename_help($path, $arg) {
switch ($path) {
case 'admin/help#yourmodulename':
   $output = '';
   $output .= '<h3>' . t('About') . '</h3>';
   $output .= '<p>' . t("A helpful entry about your module") . '<p>';
return $output;
   }
}

Thank you!!!

recommendations are no major issues and therefore NO reason for needs work.

if you think there are no major issues that must be addressed set RTBC

So it looks like you could easily enhance the existing modules? Please get in contact with the maintainer of one of the modules to discuss your ideas. I'm sure they are happy to accept your patches and/or an additional maintainer. If that fails for whatever reason and you absolutely have to push yet another acess tracking modul please get back to us and set this back to "needs review".

Sure, just close this one and re-open the other one. And thanks for helping!

added more reviews