Hi,
I've created a panel, and in IE7 the comments appears outside of the Panel (snap1).
The comment is created inside a Tab (Tabs module), however I think it is a Panel issue.
In FF2 the panel looks ok.

Here is a temporary link to my sandbox.

Amitai

CommentFileSizeAuthor
#12 tabs_iefix.patch1.3 KBrobloach
#11 Untitled_3.jpg43.92 KBrobloach
#5 Snap1_7.png10.11 KBamitaibu
Snap1_6.png19.26 KBamitaibu

Comments

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Project: Panels » Javascript Tools
Version: 5.x-2.0-alpha7 » 5.x-0.6
Component: Code » Tabs

It seems as a tab issue (not a panels one)...

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Looks to be a theme-specific CSS issue in tab presentation. In the screenshot, the text area presumably has a negative indent or some similar setting.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

I actually didn't put any specific CSS there. Also if you will click the tabs, you will see something wrong is happening there
I can provide you an admin user for my sandbox, if you would like.

Cheers,
Amitai

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

I don't have IE7.

Please try in e.g. Bluemarine. Does it display correctly? If so, the problem is a CSS issue in one or more themes.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Title: Comments don't appear correctly in IE7 » Tabs don't appear correctly in IE7
StatusFileSize
new Snap1_7.png10.11 KB

You are right, I've switched to Bluemarine and the 'Comments' appear properly.
However, If you click on the different tabs they are shifted to the right (snap1)

nathanraft’s picture

nathanraft commented

This shifting problem is caused by the ul.secondary class in either system.css or style.css (depending on theme). See Bluemarine to see where it gets stuck - no ul.secondary so it uses system.css.

Change the bottom padding to >1.5em. This makes the necessary room in IE to fix the problem.

*remember that when working with garland you will need to go to the theme config page and save it to see changes.

nathanraft’s picture

nathanraft commented

Also.. if using tabs with cck and on load it pushes up too much messing up the display under the tab add a couple of em to the .fragment class in tabs.css. Cleans it up nicely in IE.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Category: bug » support
Status: Active » Fixed

I've Changed in Tabs.CCS, under .fragment - margin-top:20px;
(Using Zen theme)

.fragment {
    margin-top:20px;
    padding: 0 10px;
}
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
robloach’s picture

robloach
he/him
commented
Version: 5.x-0.6 » 5.x-1.x-dev
Category: support » bug
Priority: Minor » Normal
Status: Closed (fixed) » Active

This problem still persists... IE7 renders the content to the right of the tabs.

robloach’s picture

robloach
he/him
commented
StatusFileSize
new Untitled_3.jpg43.92 KB

Here's a screenshot of the undesired effect.

robloach’s picture

robloach
he/him
commented
Priority: Normal » Critical
Status: Active » Needs review
StatusFileSize
new tabs_iefix.patch1.3 KB

Here's a patch to fix the issue.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Thanks. Looks good, but I'd prefer not to patch the files that came with the tabs plugin. Can we put the css in drupal-tabs.css instead? That is, is it okay for this to apply in all browsers?

robloach’s picture

robloach
he/him
commented

Yes, it is okay to apply this to all browsers, but in Safari and Firefox it will move the content down further than you want it to. This is only a fix for IE, so it should go into Tab's tabs-ie.css. This file already exists, and doesn't do IE7 justice. Adding:

.fragment {
    margin-top:5px;
}

To the IE CSS fixes resolves it.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Thanks, that makes sense.

robloach’s picture

robloach
he/him
commented
Version: 5.x-1.x-dev » master
Assigned: Unassigned » robloach
Status: Reviewed & tested by the community » Fixed

Fixed in HEAD and in DRUPAL-5.

xstevex’s picture

xstevex commented

Thanks a lot for the patch.

I had the same problem in IE6 (only IE I checked) and the patch totally fixed it.

Steve.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.