Add FullAJAX

welcome,

An automated review of your project has found some issues with your code; As coding standards make sure projects are coded in a consistent style we please you to have a look at the report and try to fix them. Anyway, note that issues found are possibly false positives and fixing all issues is not a requirement for getting through the application process.
Report: http://ventral.org/pareview/httpgitdrupalorgsandboxfedik1543626git

• Remove "version" from the info file, it will be added by drupal.org packaging automatically.
• 'Advanced on ... All human readable strings should be encapsulated within t() (except in hook_menu(), hook_schema() and watchdog())
• admin/config/development/addfullajax: I'd rather put it into user-interface, IMHO it does not have much to do with development?
• Instead of crafting all these static javascript snippets together I'd suggest you to use a single javascript file which is included on every page and using drupal_add_js with 'settings' option to tell the script what to do. This way would be most performant as js files can be aggregated and the settings can directly set without this code snippet stuff
• You got a lot of leftover out-commented debugging / testing / preparation code left in, please remove such stuff - all of it will still be available in the git history and it's hard to read such code

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

regards

• Looking at the project page as a first time reader , didnot understand what the project provide, Please put some more documentation. How i understand is, this module will provide some ajax functionality on the sepecified id's but not sure about how it works
• Error report : http://ventral.org/pareview/httpgitdrupalorgsandboxfedik1543626git

I would also highly suggest working with JavaScript files as patrikd suggested. As the code is right now it's neither readable or maintainable/understandable and its badly cachable. I know, caching shouldn't be needed as you might never do a refresh, but if you come back later on...

What editor are you using? I checked your files, can't see any whitespaces, did you try to converting to utf8, or play around with BOM, this at least works for me in most cases.

Is there a demo page somewhere? Please add some more info on what the module actually does.
I don't get anything from "Technology conversion websites and web applications in AJAX." From your GIT page I kind of get what you are doing, but what does this mean for Drupal, how does it integrate? What are the benefits?

Setting this to needs work.

Hi Fedik,

Just a couple of issues in addfullajax.module.

- On line 65, you have used HTML tags within t() function. Please avoid that. See Here.

- On line 252 i can't see the variable "$main_region" initialized.

Regards
M

It seems that ajax_links_api provides very similar functionality. Could you describe how your module differs?
We prefer collaboration over competition, therefore we want to prevent having duplicating modules on drupal.org. If the differences between these modules are not too fundamental for patching the existing one, we would love to see you joining forces and concentrate all power on enhancing one module. (If the existing module is abandoned, please think about taking it over).

When I read your description correct, the only unique functionality within your module is to do all requests automatic. You probably should provide an addon-module for ajax_links_api or contact serjas to integrate your ideas in the module.

Auto review

There are quite a lot of code standard problem: http://ventral.org/pareview/httpgitdrupalorgsandboxfedik1543626git
This is not a blocker but should be taken care of.

Manual review

1. The module is using libraries so there is a missing dependency on .info file.
2. After a correct configuration and setting the content as id, the ajax content is placed at the correct place for half a second then the full content is replaced by the requested page, and the header, admin menu and other elements have disappeared (doesn't work as expected).

Other issues

This sounds like a feature that should live in the existing ajax_links_api project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the ajax_links_api issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

Master Branch

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Additionally the branch 7.x.0.x does not meet the naming standards for branches/releases.

Duplication of functionality

Would you please describe exactly how your module differs from Load content via JQuery Ajax and why the functions provided by your module can't be integrated into that one?

Hi fedik,

We'd all like to have our modules accepted as full projects. However, stBorchert uncovered a similar module Load content via jQuery Ajax. While your module integrates with a github project, the use of the github project also appears to be loading content via ajax into a div. Is there some difference in the feature set that justify having these two separate modules? What specifically is different about your module? Make the case, and we'll reconsider.

The sandbox's git branch must be changed to 7.x-1.x not 7.x-0.x.

Master Branch

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Additionally the branch 7.x.0.x does not meet the naming standards for branches/releases.

Duplication of functionality

You have still not written down functional differences between your module and Load content via JQuery Ajax.
If you simply use a different library it would be much better to provide a patch for Load content via JQuery Ajax so users of this module could choose between the different libraries.

Additionally there are still several notices listed by out PAReview-Tool.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.