Download & Extend
Workbench Moderation » Issues

Update the summary in the vertical tabs

Posted by Bevan on June 4, 2012 at 5:49am
Project:Workbench Moderation
Version:7.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:Workbench Sprint

Issue Summary

When creating or editing content, the vertical tab summary always reads "Not published" and never changes regardless of the moderation state of the content or any of the options in the respective vertical tabs "drawer" (fieldset).

It should show the moderation state and if the log message has been changed or is missing. This patch implements that change.

AttachmentSizeStatusTest resultOperations
000-vertical_tabs_summary.patch2.72 KBIdlePASSED: [[SimpleTest]]: [MySQL] 137 pass(es).View details
Login or register to post comments

Comments

#1

Posted by ivantm on August 1, 2012 at 2:35am

The use of <strong> tags in the vertical tab message string meant that the text appeared with an underline when clicked in the default Seven admin theme, which looked a bit odd. This patch leaves out the <strong> tags.

AttachmentSizeStatusTest resultOperations
1615562-vertical_tabs_summary.patch2.68 KBIdlePASSED: [[SimpleTest]]: [MySQL] 137 pass(es).View details

#2

Posted by Bevan on August 1, 2012 at 2:56am
Status:needs review» reviewed & tested by the community

Oh yeah. I was not sure about that. This looks good.

#3

Posted by kbentham on August 1, 2012 at 4:02pm

This looks good, I will tell stevector to commit this soon.

#4

Posted by hass on September 22, 2012 at 11:39pm
Status:reviewed & tested by the community» needs work

Bugs:

  • "Current:" cannot replaced if translated.
  • Never change case of translatable strings. This is always wrong. Don't use toLowerCase() on translatable strings.

#5

Posted by hass on January 14, 2013 at 12:04am
Title:Update the summary in the vertical tabs drawer» Update the summary in the vertical tabs
Status:needs work» needs review

Reduced patch to work how core works. I'm not sure what the intention was of the previous patch, but this one fixes that the other checkboxes on the form are also shown in the summary. It just uses the text from the selected option and that's it. This patch also adds the missing jquery wrapper that caused JS errors.

AttachmentSizeStatusTest resultOperations
workbench_moderation_1615562+Update+the+summary+in+the+vertical+tabs+drawer.patch1.9 KBIdlePASSED: [[SimpleTest]]: [MySQL] 137 pass(es).View details

#6

Posted by hass on January 14, 2013 at 12:04am
Component:User interface» Code

#7

Posted by hass on January 14, 2013 at 12:05am

Removed one empty line.

AttachmentSizeStatusTest resultOperations
workbench_moderation_1615562+Update+the+summary+in+the+vertical+tabs+drawer.patch1.9 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch workbench_moderation_1615562+Update+the+summary+in+the+vertical+tabs+drawer_0.patch. Unable to apply patch. See the log in the details link for more information.View details

#8

Posted by hass on January 14, 2013 at 12:08am

Changed summary name

AttachmentSizeStatusTest resultOperations
workbench_moderation_1615562+Update+the+summary+in+the+vertical+tabs+drawer.patch1.89 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch workbench_moderation_1615562+Update+the+summary+in+the+vertical+tabs+drawer_1.patch. Unable to apply patch. See the log in the details link for more information.View details

#9

Posted by System Message on January 14, 2013 at 12:10am
Status:needs review» needs work

The last submitted patch, workbench_moderation_1615562+Update+the+summary+in+the+vertical+tabs+drawer.patch, failed testing.

#10

Posted by hass on January 14, 2013 at 12:10am
Status:needs work» needs review
AttachmentSizeStatusTest resultOperations
workbench_moderation_1615562+Update+the+summary+in+the+vertical+tabs+drawer.patch1.89 KBIdleFAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to create dependency directory.View details

#11

Posted by System Message on January 14, 2013 at 12:12am
Status:needs review» needs work

The last submitted patch, workbench_moderation_1615562+Update+the+summary+in+the+vertical+tabs+drawer.patch, failed testing.

#12

Posted by hass on January 14, 2013 at 12:14am
Status:needs work» needs review
AttachmentSizeStatusTest resultOperations
workbench_moderation_1615562+Update+the+summary+in+the+vertical+tabs.patch1.89 KBIdlePASSED: [[SimpleTest]]: [MySQL] 137 pass(es).View details

#13

Posted by hass on January 14, 2013 at 5:44pm

#14

Posted by kbentham on January 15, 2013 at 4:01pm
Status:needs review» reviewed & tested by the community

This patch looks good.

#15

Posted by stevector on January 15, 2013 at 4:50pm
Status:reviewed & tested by the community» fixed

Thanks everybody!

http://drupalcode.org/project/workbench_moderation.git/commit/0f57235d8e...

#16

Posted by hass on January 15, 2013 at 5:38pm

THX :-)

#17

Posted by System Message on January 29, 2013 at 5:40pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.