Update the summary in the vertical tabs [#1615562]

When creating or editing content, the vertical tab summary always reads "Not published" and never changes regardless of the moderation state of the content or any of the options in the respective vertical tabs "drawer" (fieldset).

It should show the moderation state and if the log message has been changed or is missing. This patch implements that change.

Comment	File	Size	Author
#12	workbench_moderation_1615562+Update+the+summary+in+the+vertical+tabs.patch	1.89 KB	hass
#10	workbench_moderation_1615562+Update+the+summary+in+the+vertical+tabs+drawer.patch	1.89 KB	hass
#8	workbench_moderation_1615562+Update+the+summary+in+the+vertical+tabs+drawer.patch	1.89 KB	hass
#7	workbench_moderation_1615562+Update+the+summary+in+the+vertical+tabs+drawer.patch	1.9 KB	hass
#5	workbench_moderation_1615562+Update+the+summary+in+the+vertical+tabs+drawer.patch	1.9 KB	hass
#1	1615562-vertical_tabs_summary.patch	2.68 KB	ivantm
	000-vertical_tabs_summary.patch	2.72 KB	Bevan

Comments

Comment #1

ivantm commented 1 August 2012 at 02:35

Status	File	Size
new	1615562-vertical_tabs_summary.patch	2.68 KB

The use of <strong> tags in the vertical tab message string meant that the text appeared with an underline when clicked in the default Seven admin theme, which looked a bit odd. This patch leaves out the <strong> tags.

Comment #2

Bevan commented 1 August 2012 at 02:56

Status:

Needs review

» Reviewed & tested by the community

Oh yeah. I was not sure about that. This looks good.

Comment #3

kbentham commented 1 August 2012 at 16:02

This looks good, I will tell stevector to commit this soon.

Comment #4

hass commented 22 September 2012 at 23:39

Status:

Reviewed & tested by the community

» Needs work

Bugs:

"Current:" cannot replaced if translated.
Never change case of translatable strings. This is always wrong. Don't use toLowerCase() on translatable strings.

Comment #5

hass commented 14 January 2013 at 00:04

Title:	Update the summary in the vertical tabs drawer	» Update the summary in the vertical tabs
Status:	Needs work	» Needs review

Status	File	Size
new	workbench_moderation_1615562+Update+the+summary+in+the+vertical+tabs+drawer.patch	1.9 KB

Reduced patch to work how core works. I'm not sure what the intention was of the previous patch, but this one fixes that the other checkboxes on the form are also shown in the summary. It just uses the text from the selected option and that's it. This patch also adds the missing jquery wrapper that caused JS errors.