The current icons for credit cards in the payment options do not have alt tags, making them less accessible.

I have a patch that adds these with a simple alt tag for the card type (e.g. visa, mastercard, etc).

Kim

CommentFileSizeAuthor
#3 add-alt-tags-to-card-types-1615754-3.patch587 byteskim.pepper
#1 add-alt-tags-to-card-types-1615754-1.patch786 byteskim.pepper

Comments

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Active » Needs review
StatusFileSize
new add-alt-tags-to-card-types-1615754-1.patch786 bytes

Patch attached.

tr’s picture

tr commented
Status: Needs review » Needs work

theme('image', ...) should be used here instead of manually creating the img tag, and the explicit styles should be removed and put into the .css. I'd also strongly prefer that this be done in 7.x-3.x first, to ensure that improvements in the code base get propagated forward.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Version: 6.x-2.x-dev » 7.x-3.x-dev
Status: Needs work » Needs review
StatusFileSize
new add-alt-tags-to-card-types-1615754-3.patch587 bytes

Added patch against 7.x-3.0-dev

Status: Needs review » Needs work

The last submitted patch, add-alt-tags-to-card-types-1615754-3.patch, failed testing.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 7.x-3.x-dev » 6.x-2.x-dev
Assigned: kim.pepper » Unassigned
Status: Needs work » Patch (to be ported)

Ported the code from uc_paypal that does something very similar, which gives better text - e.g. "American Express" instead of "amex".

http://drupalcode.org/project/ubercart.git/commitdiff/4d96430

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Patch (to be ported) » Fixed

Ported and committed in http://drupalcode.org/project/ubercart.git/commitdiff/49c2840

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.