Closed (fixed)
Project:
Special menu items
Version:
7.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
4 Jun 2012 at 09:47 UTC
Updated:
8 Jul 2012 at 16:51 UTC
Hi,
Replacing a theme function in the registry and keeping the old one is a really good practice but using just "link_default" or "menu_link_default" as old functions names, you are exposing your code to collision with other modules which could need the same as you (Menu Firstchild for example).
Here is a tiny patch without any possible side effects which prefixes theme registry keys with your module name. Thereby, your "(menul_link_default" won't be overrided.
I hope I am clear enough.
Regards.
| Comment | File | Size | Author |
|---|---|---|---|
| avoid-registry-collision.patch | 1.42 KB | duaelfr |
Comments
Comment #1
gagarine commentedThanks!
Comment #2
gagarine commentedcommited
Comment #3
duaelfrThank you :)