I'm trying to execute this code:

      foreach (acl_node_grants($user, $op) as $realm => $gids) {

as per the example in hook_node_grants permissions search in the node_access module, and getting this error:

warning: Invalid argument supplied for foreach()

What I'm trying to do is see what grants a user has for a particular node, if any. If I should be doing something else, could you please advise. The full code is as follows:

function og_user_roles_content_access_acl_check($op, $node = NULL) {
  global $user;
  $uid = $user->uid;
  if (module_exists('acl')) {
    if ($op != 'create' && $node->nid && $node->status) {
      $grants = array();
      foreach (acl_node_grants($user, $op) as $realm => $gids) {
        foreach ($gids as $gid) {
          $grants[] = "(gid = $gid AND realm = '$realm')";
        }
      }
      $grants_sql = '';
      if (count($grants)) {
        $grants_sql = 'AND ('. implode(' OR ', $grants) .')';
      }
      $sql = "SELECT COUNT(*) FROM {node_access} WHERE (nid = 0 OR nid = %d) $grants_sql AND grant_$op >= 1";

      $result = db_query($sql, $node->nid);

      $output = (db_result($result));

      if ($output > 0) {
        return TRUE;
      }
      if ($output == 0) {
        return FALSE;
      }
    }
  } else {
    return null;
  }
}

Thanks for any assistance.

Comments

somebodysysop’s picture

somebodysysop commented

Although for consistency sake, I'd like to use the acl_node_grants() format above, I did come up with a way to check acl permissions access for user:

/**
 * Called by og_user_roles_content_access_check
 * To check content_access acl permissions
 */
function og_user_roles_content_access_acl_check($op, $node = NULL) {
  global $user;
  $uid = $user->uid;
  if (module_exists('acl')) {
    if ($op != 'create' && $node->nid && $node->status) {
      $result = db_query("SELECT COUNT(*) FROM {acl_user} au INNER JOIN {acl_node} an ON au.acl_id = an.acl_id INNER JOIN {node_access} na ON na.nid = an.nid WHERE uid = %d AND na.nid = %d AND na.realm = '%s' AND na.grant_$op >= 1", $user->uid, $node->nid, 'acl');
      /**      
       * sql used:
       * SELECT COUNT(*) FROM acl_user INNER JOIN acl_node ON acl_user.acl_id = acl_node.acl_id INNER JOIN node_access ON node_access.nid = acl_node.nid WHERE uid = 61 AND node_access.nid = 376 AND node_access.realm = 'acl'
       */
      $output = (db_result($result));

      if ($output > 0) {
        return TRUE;
      }
      if ($output == 0) {
        return FALSE;
      }
    }
  } else {
    return null;
  }
}

Please let me know if this looks ok. Thanks.

salvis’s picture

salvis
he/his
commented

Your original approach to using acl_node_grants() was ok, except for it might return NULL.

http://api.drupal.org/api/function/hook_node_grants/5 does not specify what should be returned if no grants are found. The original implementor of ACL went out of his way to return NULL rather than an empty array, but obviously an empty array would be more convenient for you.

I'm trying to find out what the proper "empty" return value is.

salvis’s picture

salvis
he/his
commented
Status: Active » Fixed

The proper "empty" return value is to return nothing (NULL). So, you need to deal with that.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.