Disabling/excluding core modules results in error [#1616462]

The README explains:

The following syntax can be used to disable/exclude core modules that would
otherwise be inherited from a base install profile:

dependencies[book] = 0

When I try using this for the overlay module, and use drush to run the install profile, I get a big long error that includes this:

The following modules are required but were not found. Move them into the appropriate modules subdirectory, such as sites/all/modules. Missing modules: 0 in install_verify_requirements()

It seems that the module is assuming that the value ("0") is the module name, and not translating these config options correctly.

Comment	File	Size	Author
#4	fix_disabled_module_errors-1616462-4.patch	1.93 KB	arnested
#3	fix_disabled_module_errors-1616462-3.patch	1.9 KB	jaytennier

Comments

Comment #1

thedavidmeister commented 16 June 2012 at 09:00

I can confirm this is a problem. Just tried to disable update using the "dependencies[update] = 0" syntax and it failed.

Comment #2

TheBarnacle commented 20 July 2012 at 09:49

Subscribe.

I just tried this with "dependencies[comment] = 0" and got the above error.

Comment #3

jaytennier commented 31 August 2012 at 14:23

Status	File	Size
new	fix_disabled_module_errors-1616462-3.patch	1.9 KB

The issue appears to be that when the install_verify_requirements() task verifies the profile it checks to make sure that the dependencies listed actually exist. It does this by checking only the values of the dependencies array so it runs into a problem when it gets to a module that's been disabled using Profiler's syntax (i.e. the module name it's checking for is "0").

I've created a patch that overrides and reuses the install_load_profile() task to remove any dependencies that have been disabled from the list of modules. This lets the verify task complete without complaining and because the other install tasks that have been overridden use Profiler's profiler_v2_load_config() function Profiler's install process will still correctly merge multiple profiles.