I am reporting http://drupal.org/update/modules/6/7 to moderators because:

There is no mention of the removal of the theme key table_select_header_cell nor how to convert the code.

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Title: Moderation report for Converting 6.x modules to 7.x » Change notice missing... from converting 6.x modules to 7.x
Project: Documentation » Drupal core
Version: » 7.x-dev
Component: Missing documentation » documentation
Status: Active » Postponed (maintainer needs more info)

Can you provide any more specifics on that -- where was this theme key before, and actually, what do you mean by "theme key"?

Anonymous’s picture

Anonymous (not verified) commented

http://api.drupal.org/api/drupal/includes%21theme.inc/function/theme_tab...

"Theme key" is mentioned in the error. It is the hook you pass to the theme() API. http://api.drupal.org/api/drupal/includes%21theme.inc/function/theme/7

Anonymous’s picture

Anonymous (not verified) commented

FYI, this was phased out in favor of FAPI #type of tableselect.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Title: Change notice missing... from converting 6.x modules to 7.x » Change notice missing for tableselect theming
Status: Postponed (maintainer needs more info) » Active
Issue tags: +Needs change record

OK, I think you're saying that in D6 you could call theme('table_select_header_cell'), but in D7, you can't. That's because the tableselect theming has changed. In D6 it was rather piecemeal, and in D7, it is unified as theme('tableselect') and you don't have to do something special with the headers.

And I agree that it is not documented on
http://drupal.org/update/themes/6/7
or
http://drupal.org/update/modules/6/7

So... We need a change notice here. Someone needs to find the issue where this was introduced, and write up a change notice.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

RE #3 - right, but this change was apparently not documented on the change notices page or with a change notice node.

star-szr’s picture

star-szr
he/him
Primary language English
commented

Similar to #1632338: Change notice missing for profile_load_profile()…

Issue found via git log -S "table_select_header_cell":
#768490: theme_table_select_header_cell() is not really a theme function

I think this should be added to http://drupal.org/update/themes/6/7 or http://drupal.org/update/modules/6/7 as @jhodgdon mentioned :)

Status: Active » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.