Download & Extend
Link » Issues

Link module changes full stops "." by underscores "_"

Posted by ferkoru on June 4, 2012 at 6:44pm
Project:Link
Version:7.x-1.1
Component:Code
Category:bug report
Priority:major
Assigned:Unassigned
Status:needs review

Issue Summary

Hi there,

First of all thanks for this fantastic module.
I have an issue with how the links are displayed when a node is created.
When I am creating a node with several fields, and I enter an affiliate link in the ‘Link’ field, once the node is saved the URL displayed is different from the URL introduced.

In the example below, when the link is displayed the “.” are changed by “_”. But if I click edit, the URL in the link field is correct.

This is the link that I introduced in the ‘Link’ field:

http://ecs-es.kelkoo.es/ctl/go/sitesearchGo?.ts=1338833010331&.sig=qP9GX...

And this is the one displayed in the node:

http://ecs-es.kelkoo.es/ctl/go/sitesearchGo?_ts=1338833010331&_sig=qP9GX...

As you can appreciate, the full point after the question mark (…sitesearchGo?_ts=1338833010331…) and after the & (…&_sig=qP9GXeEFH6syBzwmzYkxmsvp1EI…), have been changed by an underscore symbol.
As I said before, if I click “edit”, the link in the field is the correct one (with the “.” Instead of the “_”), but when the node is displayed, the link is changed (and so I cannot introduce any affiliate product).

Please let me know if you need more information (is my first issue in drupal)

Thanks in advance for your time and again for this module!

Fernando

Login or register to post comments

Comments

#1

Posted by saralibrarian on June 12, 2012 at 2:18pm

Same thing is happening to me, though it replaces my "+" with underscores in the Link output. This is happening in the full node -- not a view working with fields in which I've altered the output.

#2

Posted by ferkoru on July 8, 2012 at 7:10pm
Priority:normal» major

#3

Posted by ferkoru on July 8, 2012 at 7:13pm

Please, can someone help with this?
The affiliate links don't work... :(

Thanks!!

#4

Posted by Jimmed on July 10, 2012 at 12:20pm
Status:active» needs review

Please see the attached patch, which I believe will solve the issue. The fault lies in the use of PHP's in-built parse_str() method.

AttachmentSize
Link-1616752-4.patch 941 bytes

#5

Posted by ferkoru on July 10, 2012 at 8:31pm

Hi Jimmed,

Thanks for your answer.
When I applied the patch the following notice was showed:

Notice: Undefined offset: 1 en _link_parse_str() (line 1181 from C:\wamp\www\xxxxxxx\sites\all\modules\link\link.module).

Cheers,

#6

Posted by ferkoru on July 29, 2012 at 8:29pm

A small modification of Jimmed patch fixed the problem. :)

I didn't delete this line
- parse_str($query, $query_array);
Because deleting it the URL is cut after '?'

Cheers Jimmed!

#7

Posted by ferkoru on July 29, 2012 at 8:31pm
Status:needs review» closed (fixed)

#8

Posted by dmetzcher on February 26, 2013 at 11:12am
Version:7.x-1.0» 7.x-1.1
Status:closed (fixed)» needs review

Was this patch committed to the module? I'm still having this issue without the patch applied and with the latest release version (1.1) of the Link module.

#9

Posted by ferkoru on March 4, 2013 at 3:35pm

Hi dmetzcher,

I updated the link module and happened the same problem again.
Try to replace the content of the link.module with the content I've attached in the .txt

It worked for me.

Cheers,

AttachmentSize
content of link.module.txt 40.43 KB

#10

Posted by grassriots on April 18, 2013 at 3:48am

This crept up on me today after updating last night.
Thanks for posting this. Testing now.

#11

Posted by lunk_rat on May 7, 2013 at 7:29pm

I also have this issue, and before I patch production, I am wondering if the fix will be merged soon. Thank you!

nobody click here