Link module changes full stops "." by underscores "_" [#1616752]

Hi there,

First of all thanks for this fantastic module.
I have an issue with how the links are displayed when a node is created.
When I am creating a node with several fields, and I enter an affiliate link in the ‘Link’ field, once the node is saved the URL displayed is different from the URL introduced.

In the example below, when the link is displayed the “.” are changed by “_”. But if I click edit, the URL in the link field is correct.

This is the link that I introduced in the ‘Link’ field:

http://ecs-es.kelkoo.es/ctl/go/sitesearchGo?.ts=1338833010331&.sig=qP9GX...

And this is the one displayed in the node:

http://ecs-es.kelkoo.es/ctl/go/sitesearchGo?_ts=1338833010331&_sig=qP9GX...

As you can appreciate, the full point after the question mark (…sitesearchGo?_ts=1338833010331…) and after the & (…&_sig=qP9GXeEFH6syBzwmzYkxmsvp1EI…), have been changed by an underscore symbol.
As I said before, if I click “edit”, the link in the field is the correct one (with the “.” Instead of the “_”), but when the node is displayed, the link is changed (and so I cannot introduce any affiliate product).

Please let me know if you need more information (is my first issue in drupal)

Thanks in advance for your time and again for this module!

Fernando

Comment	File	Size	Author
#9	content of link.module.txt	40.43 KB	ferkoru
#4	Link-1616752-4.patch	941 bytes	Jimmed

Comments

Comment #1

saralibrarian commented 12 June 2012 at 14:18

Same thing is happening to me, though it replaces my "+" with underscores in the Link output. This is happening in the full node -- not a view working with fields in which I've altered the output.

Comment #2

ferkoru commented 8 July 2012 at 19:10

Priority:

Normal

» Major

Comment #3

ferkoru commented 8 July 2012 at 19:13

Please, can someone help with this?
The affiliate links don't work... :(

Thanks!!

Comment #4

Jimmed commented 10 July 2012 at 12:20

Status:

Active

» Needs review

Status	File	Size
new	Link-1616752-4.patch	941 bytes

Please see the attached patch, which I believe will solve the issue. The fault lies in the use of PHP's in-built parse_str() method.

Comment #5

ferkoru commented 10 July 2012 at 20:31

Hi Jimmed,

Thanks for your answer.
When I applied the patch the following notice was showed:

Notice: Undefined offset: 1 en _link_parse_str() (line 1181 from C:\wamp\www\xxxxxxx\sites\all\modules\link\link.module).

Cheers,

Comment #6

ferkoru commented 29 July 2012 at 20:29

A small modification of Jimmed patch fixed the problem. :)

I didn't delete this line
- parse_str($query, $query_array);
Because deleting it the URL is cut after '?'

Cheers Jimmed!

Comment #7

ferkoru commented 29 July 2012 at 20:31

Status:

Needs review

» Closed (fixed)

Comment #8

dmetzcher commented 26 February 2013 at 11:12

Version:	7.x-1.0	» 7.x-1.1
Status:	Closed (fixed)	» Needs review

Was this patch committed to the module? I'm still having this issue without the patch applied and with the latest release version (1.1) of the Link module.

Comment #9

ferkoru commented 4 March 2013 at 15:35

Status	File	Size
new	content of link.module.txt	40.43 KB

Hi dmetzcher,

I updated the link module and happened the same problem again.
Try to replace the content of the link.module with the content I've attached in the .txt

It worked for me.

Cheers,

Comment #10

grassriots commented 18 April 2013 at 03:48

This crept up on me today after updating last night.
Thanks for posting this. Testing now.

Comment #11

lunk rat commented 7 May 2013 at 19:29

I also have this issue, and before I patch production, I am wondering if the fix will be merged soon. Thank you!

Comment #12

jcfiala commented 23 May 2013 at 20:51

Status:

Needs review

» Needs work

Well, here's how it goes:

1) I need a real patch. Not just "replace your whole module with this file." With that, the status would be moved to 'needs review.'

2) I need some folks to try the patch and report that it works fine for them. Said folks would then move the patch to 'reviewed & tested by the community".

And then I'd look it over, kick the tires, and merge it in!