Given more and more movement towards features based deployment, the Facebook module really needs some form of integration with Features/CTools exportables.

Attached (comment 1) is the beginning of a patch that implements said functionality, however had I the time I would really recommend a complete rewrite of the Facebook module from ground up using the CTools Export UI. Quite frankly, the current state of this module is a mess and getting this functionality as it is was a struggle.

CommentFileSizeAuthor
#1 exportable-1617080-1.patch10.02 KBdeciphered

Comments

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Active » Needs review
StatusFileSize
new exportable-1617080-1.patch10.02 KB

Patch (sponsored by Realityloop Pty Ltd) attached.

oadaeh’s picture

oadaeh commented

Based on Deciphered's comments and lack of comments from Dave Cohen, I'm curious as to the reality of modifying this module to work w/Features and/or CTools exportables.

Dave Cohen’s picture

Dave Cohen commented

I appreciate the patch contribution. I'm not a user of features or exportables. If your post had said, "I tried the patch. It does the job. No bad side effects whatsoever." That might be enough to get it pushed to git.

In short, it needs review but I'm not the best guy to review it. I apologize for not saying so sooner.

oadaeh’s picture

oadaeh commented
Status: Needs review » Needs work

I tried the patch earlier today. It does not apply cleanly, as it is several months old.

I manually applied the changes, and it mostly worked, but there is one aspect that does not.

If I have time, I will attempt to correct the one thing and submit an updated patch, although based on @Deciphered's initial statements, I'm sure there will be lots more needing to be done for full integration.

Mostly Dave, after nine-and-a-half months with no word, I wanted to know if movement on this was at all likely.

Dave Cohen’s picture

Dave Cohen commented

I'm not likely to drive it, nor to resist it.

Not sure it will ever work as desired. The basics of app configuration, the apikey and secret, really shouldn't be copied from one site to another.

The 4.x branch of this module is cleaner, and should remain cleaner. It might be easier there to export the parts that really should be exportable. Things like access tokens, app ids, secrets... I just don't think those are meant to be exported.