when accessing admin/config/content/protected_node

at sites/all/modules/protected_node/protected_node.settings.inc on line 297

very nice module BTW - all the functionality else work so far ;)

i would offer me as a maintainer if you like !

// Yeah... we're calling a Core "private" function...
_user_password_dynamic_validation();

sadly this is no longer in D7 ;)
removing the two lines make the settings page at least showing

CommentFileSizeAuthor
#1 1617766_fatal_error.patch663 bytesgreggles

Comments

ytsurk’s picture

Issue summary: View changes

iForgot

ytsurk’s picture

Issue summary: View changes

thx

ytsurk’s picture

Issue summary: View changes

take me

ytsurk’s picture

Issue summary: View changes

yeah

greggles’s picture

Status: Active » Needs review
StatusFileSize
new663 bytes

Afaict this just works.

calefilm’s picture

patch worked. Thank you!

venutip’s picture

Status: Needs review » Reviewed & tested by the community

Also confirming that the patch works. No need to call _user_password_dynamic_validation() anymore; seems inline validation / hints are automatically attached to password_confirm fields. Yay.

Anonymous’s picture

You rock. Thanks!

kim-day’s picture

I also applied the patch and it works perfectly. (I'm running drupal 7 in a multisite configuration.)

Sakrecoer’s picture

The patch works for me too, but the attached files are still not protected eventhou my file system is set to private. Anyone, any clue of what i'm doing wrong? Or is it just the state of things at this stage of the project?

ytsurk’s picture

for me it was all working fine.

you have to set the protection in the content type and then in the content itself ..
this error only prevented to see the general settings page.

Sakrecoer’s picture

Thank you for your prompt answer!! :) After a quick look i don't see anything regarding this module in the content type pages, including the fields. But i will investigate it further tonight!

Sakrecoer’s picture

hmm... found it. been a while since i looked this up. But they are indeed protected in content type as "Protectable (default is unprotected)" in "Smart Mode"...

I will play arroud with the different combinations of these modes and tell you the result!

Thanks to the devs for the great work btw!! (I don't keep any CIA secrets so this is not very urgent for me. It wouldn't change anything about data being transmitted to wrong person, a password is a password. But it could avoid my unfinished tracks from being embeded in stupid robot fake MP3 stores....)

Screenack’s picture

Patch #1 worked for me, although #7 makes me wonder if I jumped the gun applying the patch? OR, does #1 satisfy a use-case for where a module integrator failed to read the much-appreciated documentation?

Tiliann’s picture

Newbie here--how do I apply the patch? Opened protected_node.settings, found the right spot, but which lines do I need to replace? The last 10 lines are fine--the top five are totally different from what I have in my settings file.

Using D7 on a test site (Localhost, on my home computer) and getting the identical fatal error (although it only seems fatal for this module, since I can access the rest of the site).

Screenack’s picture

Tiliann: How to apply a patch with git: http://drupal.org/node/707484

greggles’s picture

@tiliann - Welcome! Take a look at this documentation http://drupal.org/patch/apply

I just tried applying the patch to the latest 7.x-1.x-dev version of the module and it applies cleanly.

The patch just removes the line in protected_node.settings.inc that calls the function _user_password_dynamic_validation();

If you manually remove that one line it should work for you as well.

Also, if anyone cares about this module I suggest becoming a maintainer. The fact that the current maintainer hasn't fixed this critical, fatal error in 4 months is a good indicator that they aren't paying very close attention.

Tiliann’s picture

The instructions are written for people who at least understand the basics. I'll figure it out sometime.

I removed the line, and now it's fine.

I'm taking lots of notes!

rudetrue’s picture

Patch worked for me as well. Thanks!

wjackson’s picture

Greggles's patch worked for me as well! Thanks Greggles!

zilverdistel’s picture

Status: Reviewed & tested by the community » Closed (fixed)

Hey guys,

All seems good. I committed in http://drupalcode.org/project/protected_node.git/commit/085a8a7.

Thanks for looking into this!

Zilverdistel

zilverdistel’s picture

Issue summary: View changes

fixed