system.menus-rtl.css still loads even if system.menus.css is disabled in .info file when viewing in rtl mode (tested using arabic).
adding..
stylesheets[all][] = system.menus-rtl.css
..to the .info file resolves this. Trivial to patch, so posting for your review.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | zen-rtl_bug-1617996-6347786.patch | 942 bytes | KrisBulman |
| #4 | system-menus-rtl-disabled-screenshot.png | 202.68 KB | KrisBulman |
| #3 | system-menus-rtl-screenshot.png | 159.28 KB | KrisBulman |
Comments
Comment #1
johnalbinSay what?
That has to be a core bug. :-\
Comment #2
johnalbinI just searched core's queue and I'm not seeing an existing issue about this. Can someone confirm this behavior?
Comment #3
KrisBulman commentedSteps to reproduce:
Comment #4
KrisBulman commentedAdding
stylesheets[all][] = system.menus-rtl.cssto your .info file, and following the same steps will show that it does not load. (see screenshot)Comment #5
KrisBulman commentedPending someone else being able to reproduce this problem, here is a patch. Documentation should probably be added if there is a core bug to link to ( I can open the ticket if no one has yet after confirmation ). I really hope it's something specific to my setup, and not a core bug though as it's a pretty annoying problem.
I thought of removing the RTL stylesheets the old way (in a function) if RTL is on.. I'm not actually sure it's possible without attempting it, but finding out which system stylesheets are being disabled just to disable concurrent RTL seems overkill.
Comment #6
KrisBulman commentedTested in Stark, and confirmed that it is a core "bug". But likely just a documentation piece IMO.
#1785804: RTL stylesheets still load even when parent LTR ones are disabled in .info
Comment #7
KrisBulman commentedHey John, I checked with Jacine and it turns out this IS a core bug, and none of the patches against it have been accepted.
See comment #74 in #575298: Provide non-PHP way to reliably override CSS where she states we still have to manually deal with RTL files. I closed the core ticket as a duplicate after finding this out.
Perhaps we should stick with hook_css_alter()?
Moving forward with this ticket #1549160: Implement Styles Options via hook_css_alter() seems the most appropriate, so I will be setting this ticket as needs work.
Comment #8
KrisBulman commentedComment #9
johnalbinI reopened the core issue, #1785804: RTL stylesheets still load even when parent LTR ones are disabled in .info. It should be fixed there. Marking this as a dupe of that one.