Remove entity_uri() in favor of EntityInterface::uri()

Please watch out to not remove the sprint tags to avoid the issue moving out of our radar. :/

Conversions are straight forward and look good. But we also need to remove the function as well as all the references to it:

core/includes/common.inc: *     set if url() is invoked by entity_uri().
core/includes/common.inc: *     generated. Only set if url() is invoked by entit
core/modules/entity/entity.module:function entity_uri($entity_type, $entity) {
core/modules/entity/lib/Drupal/entity/Entity.php:   * @see entity_uri()

+++ b/core/includes/common.inc
@@ -2033,10 +2033,11 @@ function _format_date_callback(array $matches = NULL, $new_langcode = NULL) {
+ *   - 'entity_type': The entity type of the object that called url(). Only set
+ *     by Drupal\entity\Entity::uri() but is not used anywhere.

It's not used anywhere sounds like it is for nothing, but it isn't. It's available to hook_url_outbound_alter(). Thus, let's don't add that. (for $entity as well)

Once we already change the comment I think we can fix this part at the same time as well, i.e. let's remove the $entity_type option.

I don't think so. Where would you use that entity_uri callback? I can't imagine a use case and we don't have one in core.

+++ b/core/includes/common.inc
@@ -2037,10 +2037,10 @@ function _format_date_callback(array $matches = NULL, $new_langcode = NULL) {
- *   - 'entity_type': The entity type of the object that called url(). Only
- *     set if url() is invoked by entity_uri().
- *   - 'entity': The entity object (such as a node) for which the URL is being
- *     generated. Only set if url() is invoked by entity_uri().
+ *   Modules can add more elements into this array to give more context. url()
+ *   does not directly use them, but hook_url_outbound_alter() implementations
+ *   may do. Drupal\entity\Entity::uri() sets two elements: 'entity' and
+ *   'entity_type'.

Why that docu change? It should read as previous, but just remove the entity type document and fix the reference to entity_uri. Then of course we have to fix the invocation to don't include the entity type as well.

Changing that documentation changes how that is supposed to be used, what needs discussion and a separate issue. So let's focus on deprecating entity_uri() here.

Patch looks good!