Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
6 Jun 2012 at 09:53 UTC
Updated:
10 Jul 2012 at 07:44 UTC
Jump to comment: Most recent file
Comments
Comment #1
DavidS commentedWhy you didn't implement formatter for Address Field? Here is API documentation: http://drupalcode.org/project/addressfield.git/blob/refs/heads/7.x-1.x:/addressfield.api.php. Also you can see example sub-module in the addressfield module directory.
There is some errors in code style when I ran it using PAReview. Here is results: http://ventral.org/pareview/httpgitdrupalorgsandboxlcnphp1611614git
Comment #2
lcnphp commentedComment #3
DavidS commentedAlso, you need to clean up your master branch. The most direct documentation on this is Moving from a master branch to a version branch (see p.5).
Also, please fix the name of the D6 branch: it should be called not
6.x.-1.xbut6.x-1.x.Also after some manual reviewing I found this code:
because it won't work any time because of some server limitations.
So I can suggest some possible solutions:
Comment #4
lcnphp commentedImplementation formatter for Address Field was done.
Comment #5
lcnphp commented1. add implement formatter for Address Field
2. fix some code style error
Comment #6
DavidS commentedSome comments on new changes:
hook_install. Using this solution you didn't simplify the query, but you have increased the load on mysql server. because now, instead of one query, you are executing two queries.hook_uninstall()).Comment #7
rogical commentedthe author said no need anymore.