I am using the Site Notes module, which creates a custom content type. When I edit those nodes, the edit tab at the top of the pages goes blank. This does not happen if I disable Meta Tags. I really don't see why this is happening, but it is completely reproducible on all my sites. BTW, it also happened with the 1.3 release too.

Comments

nancydru’s picture

Is anything happening on this? I thought it was fixed, but don't see that documented here.
?

Robrecht Jacques’s picture

Assigned: Unassigned » Robrecht Jacques

Hmm, I thought this was fixed too.

Does it only happen with the Site-notes content type? Or with all content types?

nancydru’s picture

That's the only one I saw it on, but it was the only custom content I had at the time. After I tracked down what was causing it, I removed the module, so I don't know if it would be affecting what I've done since then.

nancydru’s picture

StatusFileSize
new12.56 KB

Yes, this is still happening in 5.5. It does appear to only be on the "sitenote" type, but it is merely a story clone. I have looked at my module and can find no reason for this to happen, and it does not when the Meta Tags module is not enabled.

I've attached a screenshot of the page in edit mode.

Robrecht Jacques’s picture

Project: Nodewords: D6 Meta Tags » Site Notes
Version: 5.x-1.5 » 5.x-1.2
Assigned: Robrecht Jacques » Unassigned
Status: Active » Needs review
StatusFileSize
new1.01 KB

I believe this is a bug in sitenotes, so I'm moving this issue.

The problem seems to be with menu_set_location() that you use in sitenotes_view(). Other modules which create a node type in core and want to set the breadcrumb, like book, blog or forum, wrap that function in a if ($page) { ... } or if (!$teaser) { ... } , so I'm guessing this is needed somehow.

Probably nodewords could do something to avoid this problem, but I have no clue what. The reason nodewords calls sitenotes_view() is to autogenerate a description. Maybe it should do that some other way ??

Patch attached.

nancydru’s picture

Status: Needs review » Fixed

Hmm, interesting. This was the first module I wrote, so I have to claim ignorance at that point.

But that does seem to fix the problem. Thanks.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.