Broken logic in indexing of extra data

Looks good to me, committing to D7. Gave credit where credit was due :-)

Multiple backports:

#1576710: Indexing with drush cron generates a lot of invalid cron notifications
#1522174: hook_node_type_delete is wrong
#1586320: Add support for the ExternalFileField field type
#1588256: Warning: Invalid argument supplied for foreach() in apachesolr_entity_update() (line 1766 of /apachesolr/apachesolr.module)
#1630222: Fatal error: Cannot use string offset as an array in /sites/all/modules/contrib/apachesolr/apachesolr.module on line 1698

Use this one if you want to close those issues.

I test it in my site ... see what happen with the simpletest.

I'm gonna stop now start the match :D

Woa, can't you split them in separate issues. Will be easier to review :-)

Thanks for all of your effort!!

Yes, I can, but I did a mistake, I did not split the code issue by issue.

So the lines is not 100% percent accurate with the last pull I did :/

I did a git pull origin 6.x-3.x after each diff I did.

I need to learn split the code for each issue :/

committed pwolanins patch to D6. killua, thanks for the effort anyhow. I think you'll do better next time ;-)