Closed (fixed)
Project:
Views (for Drupal 7)
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
7 Jun 2012 at 15:01 UTC
Updated:
13 Aug 2012 at 00:11 UTC
Jump to comment: Most recent file
Comments
Comment #1
nils.destoop commentedAttached is a patch
Comment #2
dawehnerActually i think that the block display might not appear at all if there is no block module installed, though this might cause a lot of additional problems if we do that.
Lets go with this patch, thanks for writing one! Just added a comment + proper indentation.
Comment #3
dawehnerThanks for the patch! Committed it to 7.x-3.x and 8.x-3.x
Comment #4
andypostYou better use db_table_exists() because module could be installed but disabled
Comment #5
dawehnerFeel free to post a follow-up patch.
Comment #6
andypostSuppose code comment is ok, just need to check block's table.
module_exists() returns TRUE only if module installed and enabled
Comment #7
dawehnerI'm not sure, but why would you want to update the block table if you don't have the block module installed ...
At least in most cases you expect that the table data is not changed anymore once you have disabled a module.
Comment #8
dawehnerAfter some dicussions i realized you were right! Committed to both 7.x-3.x and 8.x-3.x
Comment #9
andypostWe need this because of block module could be installed but disabled