somehow the button has placed itself about 5-6 fields below username...below captcha...

can u help me put it next to the Username..or right below it..and before email address
thanks

Comments

zigma’s picture

did you find a way to theme this so that it can appear below username?

gurukripa’s picture

no..4 now..i disabled the module :(

2c’s picture

Title: this shows below captcha not alongside Username » Same problem

On the registration page the 'check availability' button is far down the page...it is not directly under the username field as it should be (for usability).

My registration page currently looks like this...

Username:
Email:
Password:
Reconfirm password:

I'd prefer it to look like this...

Username:

Email:
Password:
Reconfirm password:

jefflowder’s picture

Within the user_check.module I changed:

$form['username_button'] to be $form['account']['username_button']
$form['username_message'] to be $form['account']['username_message']

In a seperate module using hook_form_alter() I changed the weighting like so:
$form['account']['name']['#weight'] = -1;
$form['account']['mail']['#weight'] = 2;

Then the username_button will sit in the middle - its then up to you to put in the appropriate CSS to line them up if you need to.

Hope this helps

Christefano-oldaccount’s picture

Title: Same problem » this shows below captcha not alongside Username
Status: Active » Needs review
StatusFileSize
new596 bytes

phonydream2, please don't change the title. The title of issue are different from comments in the forum.

To get more eyes on this, I've attached a patch with jefflowder's improvement. It doesn't get us all the way there, though, so hopefully someone (jefflowder?) will flesh out the rest of the form.

Arieh’s picture

Status: Needs review » Needs work

Hi.

Thanks for the patch. I applied it and it looks much better now. Suggested improvements:

1) place "check availability" button on the right from the username field on the same line;
2) make both fields (username and email) shorter (change in Drupal core?).

I would like to do it myself and post a patch(es) here, but I am not php developer and not proficient in theming :(
Anyway, thank you jefflowder for the code and christefano for the patch. It is now usable button.

Arieh

Christefano-oldaccount’s picture

Status: Needs work » Needs review

Thanks for the review. I'm not the maintainer of the module but I think it's important to have more feedback before changing the status to needs work: making the fields shorter and placing the button on the right (which can be done with CSS) are beyond the scope of this specific issue.

rolandk’s picture

I'd like to second this request. The check availablity button needs to be next to the username field if at all.

CAn I suggest that this mod (like yahoo) needs to be fired when focus leaves the username field. It need not be on a button click event.

This way it will appear seamless and not another step. This way it won't matter where the button is, as there won't be a button... just code.

Thanks for a great mod.

bowwowadmin’s picture

subscribing with a smile

ksenzee’s picture

Category: support » bug
StatusFileSize
new2.1 KB

The attached patch moves the button just below the username field, where it belongs. It also incorporates a couple of whitespace fixes, and changes the "unfortunatly" text. I know it's not ideal to have more than one fix per patch, but I didn't take time to split out the changes. Sorry.

christefano’s picture

The patch at #10 works but it's a bit wonky in both Firefox and Safari. Attached are screengrabs of what the form looks like in Safari and a before-and-after in Firefox.

I'm hesitant to change the status since we now have two patches. Both need to be tested and both need work, in my opinion.

ksenzee’s picture

Status: Needs review » Needs work

Sorry, forgot to clarify that the patch in #10 incorporates the patch in #5. It does need work still -- it looked a lot better than that in FF/Win but I didn't take time to check it anywhere else. When I do find some more time for this, though, I'd rather work on making the check happen on keypress, so we can make that button go away entirely.

heather’s picture

ooo i hope it's ok if i subscribe to this.

Rosamunda’s picture

subscribing...

ardas’s picture

Status: Needs work » Fixed

Thank you guys for all work you did. We have ported this module to Drupal 6 and added features you proposed to both Drupal 5 and 6. The release will be ready soon. Please download it and test.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.