Needs review
Project:
Pleroma
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
26 Jul 2007 at 13:34 UTC
Updated:
22 Aug 2007 at 20:37 UTC
Jump to comment: Most recent file
Are there any upgrade plans for Drupal 6 or anyone working on it?
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | Pleroma.drupal6_0.patch | 1.68 KB | Freso |
| #2 | Pleroma.info_.txt | 309 bytes | Freso |
| #1 | Pleroma.drupal6.patch | 1.68 KB | Freso |
Comments
Comment #1
Freso commentedFrom http://drupal.org/node/132442, it seemed like it would not require too much meddling to get this working on Drupal 6.
A patch attached, Pleroma.info coming up. Not yet tested, so please do.
Comment #2
Freso commentedAnd .info file. (Rename to "Pleroma.info" - drupal.org apparently doesn't accept uploads with the ".info" extension.)
Comment #3
Freso commentedI just tested on a Drupal 6 CVS install, and PHP (5.2) didn't like the curly brackets, so they're now gone.
I've noticed a few notices though ( plus content_bottom on line 60), but I'm not sure whether these were really there as well in the Drupal 5 version. Either way, since the notices are obviously visible now, they should probably be worked around. Using
if empty($content_[top|bottom])might result in proper behaviour, but I do not wish to go further unless someone gives me the "Go!". It might of course also be that$content_[top|bottom]doesn't exist any more, but I haven't seen this documented anywhere...Comment #4
Freso commentedIt should of course be
if !empty($content_[top|bottom])(note the !).Comment #5
Freso commented$has_termsin node.tpl.php:11,17 also appears to have problems with definition. Changing the check to!empty($has_terms)instead removes the notice. Neither results in a listing of taxonomy terms.Comment #6
Freso commentedI guess I need to know whether this patch actually causes behaviour to change or not, before claiming it needs work. So I'll put it back to needs review and hope that someone will take a minute to review it.