Remove chameleon pipe when site has no slogan.

simon.males - July 26, 2007 - 14:44
Project:Chameleon
Version:7.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs work
Issue tags:chameleon
Description

If a site has no slogan, pages outside of /admin will produce an unwanted pipe (|). The pipe will appear after the site name, before the non-existent slogan.

The patch suggests a method of suppressing the pipe for only when the site has a slogan.

AttachmentSize
chameleon.theme__0.patch1.05 KB

#1

simon.males - July 26, 2007 - 14:45
Title:Remove chameleon pipe with site has no slogan.» Remove chameleon pipe when site has no slogan.

#2

simon.males - January 6, 2008 - 23:43

Continues to be an issue in 6.0-rc1

#3

simon.males - January 25, 2009 - 14:09
Status:needs work» needs review

This is still an issue in 6.x-dev. Attached new patch with a single coding style change.

AttachmentSize
chameleon.theme__1.patch 1.02 KB

#4

simon.males - January 26, 2009 - 08:44
Version:6.x-dev» 7.x-dev

Updated the patch to 7.x-dev.

AttachmentSize
chameleon.theme_.d7__2.patch 980 bytes

#5

System Message - January 26, 2009 - 19:30
Status:needs review» needs work

The last submitted patch failed testing.

#6

simon.males - January 30, 2009 - 10:59
Status:needs work» needs review

Looks like test bot doesn't like the diff of two files, now attaching cvs diff

AttachmentSize
chameleon.theme_.d7__3.patch 1.19 KB

#7

System Message - January 30, 2009 - 11:25
Status:needs review» needs work

The last submitted patch failed testing.

#8

simon.males - January 30, 2009 - 13:22
Status:needs work» needs review

Okay word on the street is I need to do cvs -uRp diff from drupal root. Argh!

AttachmentSize
chameleon.theme_.d7__4.patch 1.24 KB

#9

System Message - February 7, 2009 - 05:40
Status:needs review» needs work

The last submitted patch failed testing.

#10

mr.baileys - March 10, 2009 - 07:21

#11

mr.baileys - March 10, 2009 - 07:22
Project:Drupal» Chameleon
Version:7.x-dev» 7.x-1.x-dev
Component:theme system» Code

Forgot to change queue...

 
 

Drupal is a registered trademark of Dries Buytaert.