Hello there,

I use audio (5.x-2.x-dev) module which is bundled with DrupalEd package. I try to create node type "audio" and upload mp3 audio file for several times, as far as I check, uploading process is fine, embed player is shown, but I can't play _any_ audio and got error message _Error opening file_. As I check the html code using Firebug, I saw something strange in this code

<div class="content"><object type="application/x-shockwave-flash" data="/fuse/sites/all/modules/audio/players/1pixelout.swf" height="24" width="290">
  <param name="movie" value="/fuse/sites/all/modules/audio/players/1pixelout.swf">
  <param name="wmode" value="transparent">
  <param name="menu" value="false">
  <param name="quality" value="high">
  <param name="FlashVars" value="soundFile=http%3A/%252Fwww.fuse.in.th/fuse/audio/play/189">
  <embed src="/fuse/sites/all/modules/audio/players/1pixelout.swf" flashvars="soundFile=http%3A/%252Fwww.fuse.in.th/fuse/audio/play/189" height="24" width="290">
</object><br>4:42 minutes (1.13 MB)<p>testetstestst</p>
</div>

The flashvars _soundFile_ is encoded as http%3A/%252Fwww.fuse.in.th/fuse/audio/play/189 instead of which is curious to me because the last / of :// has been replaced by %252F and I think it cause player error.

Check my uploaded files here
http://www.fuse.in.th/fuse/audio

CommentFileSizeAuthor
#16 audio_162379.patch4.84 KBdrewish
#12 audio_urlencode_1.patch4.78 KBmfb
#8 audio_urlencode_0.patch4.54 KBmfb
#3 audio_urlencode.patch939 bytesmfb

Comments

mfb’s picture

mfb
they or he
commented

This also affects audio module 5.x-1.x-dev.
It looks like the changes to drupal_urlencode(), and by extension, drupal_query_string_encode(), between Drupal 5.1 and 5.2 are not compatible with the flash player. I'm not yet sure what the solution is.

mfb’s picture

mfb
they or he
commented

relevant links,
http://drupal.org/node/158687
http://cvs.drupal.org/viewvc.py/drupal/drupal/includes/common.inc?r1=1.6...

mfb’s picture

mfb
they or he
commented
StatusFileSize
new audio_urlencode.patch939 bytes

here's a quick work-around for the 1pixelout player, just to get it working with drupal 5.2..

lyricnz’s picture

lyricnz commented

Doesn't that patch break the possibility of the $options parameter being non-empty?

mfb’s picture

mfb
they or he
commented

Not a solution just a quick work-around to get the player working..

drewish’s picture

drewish commented

marked http://drupal.org/node/162712 as a duplicate

drewish’s picture

drewish commented

marked http://drupal.org/node/163087 as a duplicate.

mfb’s picture

mfb
they or he
commented
Version: 5.x-2.x-dev » 5.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new audio_urlencode_0.patch4.54 KB

Assuming the issue in drupal core 5.2 won't be resolved any time soon, here's a better work-around: create a new query_string_encode function which calls the plain php urlencode function.

kengggg’s picture

kengggg commented

thanks for your works mfb, but i can't apply the lastest patch on my test box. i got error on patching audio.module

[audio]$ cat audio.patch |patch -p0
patching file audio.module
Hunk #1 FAILED at 1658.
mfb’s picture

mfb
they or he
commented

Is it failing because you're using 5.x-2.x-dev branch of audio module? I could prepare a patch for that branch too if needed.

kengggg’s picture

kengggg commented

yeah, i using 5.x-2.x-dev branch of audio module right now. if you prepare the patch for dev branch, it would be highly appreciated :D.

mfb’s picture

mfb
they or he
commented
StatusFileSize
new audio_urlencode_1.patch4.78 KB

here's a patch on HEAD (there is no DRUPAL-5--2 branch yet).

drewish’s picture

drewish commented

here's a re-roll with some phpdoc fixes. it seems to work for me but i wanted to hear back from zirafa if it helps with #147888 or if it can be modified to fix that too... maybe it's best to just commit this so the -dev releases work though...

jwolf’s picture

jwolf commented

Not to beat a dead horse here but... maybe this info may help.
I've noticed that when "clean urls" is enabled, this breaks the 1pixelout Flash player. Prior to enabling clean urls, everything works fine.
Getting a "error opening file" with 5.x.-1.1 and 5.x-1.x-dev using Drupal-5.2

mfb’s picture

mfb
they or he
commented

drewish, i think you forgot to attach the patch ;)

drewish’s picture

drewish commented
StatusFileSize
new audio_162379.patch4.84 KB

mfb, right you are ;)

zirafa’s picture

zirafa commented

I think this is unrelated to #147888 because the issue there is more about how to use exposed filters on XML feeds generated by views. Any advice on that thread is appreciated though.

p.s. this patch worked for me

drewish’s picture

drewish commented
Status: Needs review » Fixed

mfb, thanks for taking care of that. committed to HEAD and DRUPAL-5. i'll probably have to roll a new release pretty soon.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)