Hi,
it's nice to see that someone is working on this again. Thanks, beginner.
I've found a minor problem with blogtheme:
When a user selects a theme for his/her blog, this information is lost on the comment form (as it is handled by the comment.module).
That means that another user (not the blog owner) commenting on a blog entry will either
- be redirected to the comment form and loose the blogtheme if "comments under entry" is switched off
- or redirected to comments preview and loose the blogtheme if preview is mandatory
- or redirected to comments preview if preview is not mandatory but he/she uses the preview function of the comments module (can't be switched off) and looses the blogtheme as well
As you see, if you turn on the comment form directly on an entry page and do not force the preview function, this behavior of blogtheme is a rather minor nuisance as it only applies to a "previewed" comment. The problem grows if comments preview is mandatory or if the comment form is not set directly under an entry.
I guess that to solve that problem is harder as I imagine it means playing around with the comment.module as well.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | blog_theme-theme-consistency-in-comment-module.patch | 1008 bytes | chris21 |
| #3 | blog_theme-theme-consistency-in-comment-module.patch.txt | 1008 bytes | chris21 |
Comments
Comment #1
chris21 commentedOk, tried to solve this myself:
in blog_theme.module,
add
after the
This works for me, but I'm new to drupal and its code so please report on any problems or suggestions you have.
Will produce a patch file as soon as I know how to produce one...
Comment #2
beginner commentedThis can be considered a useability bug, since it is confusing to the users.
To create a patch:
http://drupal.org/patch/create
(If you use a windows machine, make sure you use UNIX-like end of lines, like explained in that link).
Comment #3
chris21 commentedOk, I tried to create a patch file using tortoiseCSV on a windows machine and dos2unixed it. Tell me if it is messed up... The patch file should bring the changes as described in my second post above, adding a case 'comment' to the function.
If this patch file produces not the intended result, that is, making the theme chosen by the blog author consistent through the commenting process on any of his/her blog entries, please report here.
This patch is only tested for the core comment.module. So far it is not tested for the comments as nodes contributed module or in regard to any other changes on the core comment.module. If anyone is eager to test it with a different comment.module, go ahead and tell me the result.
The patch still needs review, don't test it on a live site.
As I am new to drupal, I can't forsay if the patch could produce a performance issue while handling all blog entry comment preview/submit pages.
Comment #4
chris21 commentedSorry, the previous attached patch file has a .txt ending that should not be there.
Here is the patch file again.
I guess I have to get myself a linux install...
Comment #5
beginner commentedThe .txt extension does not matter.
The patch applies cleanly, and it seems to work.
I changed $cid (comment ID) to $nid (node ID) since that's what it is, then committed it: http://drupal.org/cvs?commit=74991 .
thanks.
The patch is part of the 5.x-1.2 release.
Comment #6
(not verified) commented