Twitter upgrade for Drupal 6

I'm having trouble getting this to work. It seems like the appropriate database tables were not installed.

Jeff, your most recent patch throws this error on activation of the twitter integration modules:

Fatal error: Cannot redeclare twitter_integration_install() (previously declared in .../sites/all/modules/twitter/twitter_integration.install:9) in .../sites/all/modules/twitter_integration.install on line 10

On /user/%/twitter and /user/%/edit/twitter -- received error before any twitter information was yet saved:
user warning: Table 'db203_sirkitree.twitter_account' doesn't exist query: SELECT *, tu.screen_name AS screen_name FROM twitter_user tu LEFT JOIN twitter_account ta ON (tu.screen_name = ta.screen_name) WHERE tu.uid = 1 in /home/203/domains/sirkitree.net/html/sites/all/modules/contrib/twitter/twitter_integration.module on line 286.

Then upon trying to save user information on /user/%/edit/twitter I've attached the list of errors as a screenshot. These are happening because the twitter_account table is not being created in the install process. There is twitter_user and twitter_node, but no twitter_account.

Also, now that I've tried to save, I have a permanent error message on my front page:
user warning: Table 'db203_sirkitree.twitter' doesn't exist query: SELECT t.* FROM twitter t LEFT JOIN twitter_node tn ON t.twitter_id = tn.twitter_id WHERE tn.nid = 6 in /home/203/domains/sirkitree.net/html/sites/all/modules/contrib/twitter/twitter_integration.module on line 191.

This is displayed 6 times, even though I have no block displayed or anything. Should there be a call to this module from the front page?

Yeah they never showed up. Here's a directory listing:

/twitter$ ls
CVS twitter.module twitter_actions.info twitter_block.info twitter_integration.info twitter_integration.pages.inc
twitter.info twitter.patch twitter_actions.module twitter_block.js twitter_integration.install twitter_log.info
twitter.info.orig twitter.views.inc twitter_block.css twitter_block.module twitter_integration.module twitter_log.module

Thanks eaton, much better. I can use this on my site, so cool!

However, I am getting error on /user/% now:
warning: call_user_func_array() [function.call-user-func-array]: First argument is expected to be a valid callback, 'theme_twitter_integration_status' was given in /home/203/domains/sirkitree.net/html/includes/theme.inc on line 591.

Looks like maybe you forgot to add function theme_twitter_integration_status(){...} which is called on the provided blocks for theming $items[]

hi eaton,
I took the patch from comment#11 and applied it on the twitter module I downloaded from http://drupal.org/project/twitter(right?). Drupal refuses to alow me to enable to plugin saying the version is incompatible. looking at twitter.info, I see the version remained 5 -

I could've fixed it myself, of course, just to allow deployment, but I'm afraid that it indicates I'm doing something wrong (being an almost complete newbie) or that there are other files which aren't up to date.

could you please assist?

thanks,

I patched and uploaded the module using the patch from comment #11. I can see most of the funtions - actions, can configure Twitter user/password in profile - but the Tiwtter import and roll up as a node function seems absent? From the code this should also be configured from the profile but no options appear. Any ideas?

Eaton: why not talk to walkah about taking over or co-maintaining this module?

Will this module enable people to choose particular people they want to hear from - on say drupal - and get the messages that they have posted (with a twitter when they do).

This patch is awesome!

Wow, great work on this! Was playing around with a patched up version (patch #11 didn't apply properly, btw), but I fell at the first hurdle - the form at /user/uid/edit/twitter doesn't submit/save the settings properly. Eaton, is it worth me starting to poke around with this, or is there another patch on the way?

i patch twitter 5.x-1.x-dev with post #11. and i am getting this error Fatal error: Call to undefined function dsm() in /homepages/5/d244557972/htdocs/modules/twitter/twitter.module on line 114

this is when i was adding my twit username and password to my profile

Looks like you've patched with the very first patch in the thread (in the first post or comment #1, not #11), which contained a debug call to dsm() - an aid for developers using the devel module.

Try the more recent patch #11 and see how it goes!

I'd say commit this and then create new issues for problems that popup.

...

i'm getting the same error as sirkitree at #12, after installing all the new modules, activating the three provided blocks, and setting up my user twitter status.

and that's with the patch at #11

I should add - a super huge thanks to Eaton for all his awesome work on this patch. It's been a fun topic of debates whenever we're together ;-)

subscribed :)

A request - perhaps I overlooked something, but I had no idea this module was now PHP 5 only until after I'd downloaded it, run the patch, and went to the module administration page. Maybe I missed a note somewhere? A readme file or something along those lines would be a good thing to add.

I was pretty disappointed that I didn't get to play with the new features. They sound nifty.

(...and no, I don't have any hope of being able to move to PHP 5 soon, so unless Scylla or Charybdis opts to pity me, I'm out of luck here.)

Hi gang,

I'm new to this thread/module and have some questions, observations:

1. Are all patches against the June, '07 dev D5 version?
2. There is no D6 branch version on the project page. Anything in particular holding this up? Is that what is also causing the issues that are really D6 to be labeled as D5?
3. Seems like Jeff Eaton's work on the D6 version constitutes an almost total reworking of the module. I'd love to hear Eaton's assessment on how much work it would be to back port it to D5.
4. There is some modest amount of work that has gone into improving the D5 version. Pending anyone committing to back-porting Eaton's work, it would make sense to commit that work to another dev version of Twitter D5.
5. The project page gives no hint to all the work that has gone on and is going on regarding this module. I think that's confusing to visitors just happening by.

Shai

Jeff,

Thanks so much for spelling all that out! I agree with your conclusion in #4 that modest improvements already being worked on should be applied to 5. And the all new Twitter for D6 is just one more motivation for movin' people along to D6.

When you release it I think that its tag should be 6--2-0, don't you think? And the release for D5 would be 5--1-0. This way it's pretty clear from the tags alone the code is significantly different between the D5 and D6 versions, not simply a port.

Best,

Shai

"When you release it I think that its tag should be 6--2-0, don't you think? And the release for D5 would be 5--1-0. This way it's pretty clear from the tags alone the code is significantly different between the D5 and D6 versions, not simply a port."

Sounds sensible to me!

Jeff,

Awesome! Congratulations.

Now that Twitter for D6 has a warm and cozy home in CVS, do you see any reason not to commit the modest improvements a few of us have been working on for Twitter D5?

I've sent a note to Walkah for co-maintainer status. I see myself solely focusing on the D5 version for now.

But it's fine with me not to be a mainainer if you or James went ahead and made the commit. One reason why I'm kind of urgent to update the .dev version is that there are still a bunch of fixes to be made and it would be nice to have more focused patches on top of a more recent base point than one that is more than a year old.

Shai