notify shippment

vitass - July 27, 2007 - 08:11
Project:e-Commerce
Version:5.x-3.x-dev
Component:shipping
Category:bug report
Priority:normal
Assigned:Unassigned
Status:active
Description

Transactions->workflow-> trying to send mail for shipping notify: ERROR:

"Mail template for ec_mail_shipping_notification could not be found!"

There is not such template mail in EC_MAIL at all.

Also if send custom mail from mail form, the status of transaction does not changed to "Shipped"

#1

brmassa - July 27, 2007 - 10:35
Assigned to:vitass» brmassa
Status:active» patch (to be ported)

Gordon,

i commited this patch against eC4 but its not on ec3.2. see issue #140445
simply, just change shipping.module on line 113: MAILVAR_SHIP_NOTICE instead ECMAIL_TYPE_SHIP_NOTICE.

regards,

massa

#2

brmassa - July 27, 2007 - 10:43
Status:patch (to be ported)» active

@Gordon,

testing i got some bugs but i think its due some update problem. after a careful look, i see the patch WAS commited and its now working just fine.

@Vitali,

well, as i just said, its working fine to me. the email exist and it changes to shipped.

regards

massa

#3

vitass - July 28, 2007 - 08:52
Status:active» closed

Thank you guys, I haved changed the strings in shipping.module and it works fine now..

#4

JohnAlbin - September 13, 2007 - 17:19
Version:5.x-3.2-rc2» 5.x-3.x-dev
Component:ec_mail» shipping
Priority:normal» critical
Status:closed» needs review

There are two problems that I can see.

  1. After doing a clean install of ecommerce (including shipping.module), there are only 4 items in the ec_mail table. There is no default shipping notification email. This is probably because ec_mail_reset_to_defaults(ECMAIL_TYPE_SHIP_NOTICE, 'shipping') failed to run properly in shipping.install file.
  2. Also, there is no way to set the default shipping notification email because HOOK_settings() is deprecated in D5, so shipping_settings() is never called.

The attached patch does NOT address the first problem; I don’t have the time to investigate this. The patch changes to shipping_settings() into some form_alter() code.

AttachmentSize
shipping-settings.patch 1.65 KB

#5

brmassa - September 14, 2007 - 02:36
Status:needs review» fixed

John,

thanks for the patch. its fixed on eC4

regards,

massa

#6

JohnAlbin - September 14, 2007 - 16:52
Status:fixed» needs review

Are you not applying bug fixes to EC3 anymore? EC4 is only in alpha.

#7

brmassa - September 15, 2007 - 21:22
Priority:critical» normal
Status:needs review» fixed

John,

we are not developing eC3 anymore, granting the next version more attention.

regards,

massa

#8

Anonymous - September 29, 2007 - 21:33
Status:fixed» closed

#9

tknospdr - March 20, 2008 - 20:22
Status:closed» active

I attempted to run this patch but got this as output, and it didn't work.

david:/Volumes/david/Sites/d5/sites/default/modules/ecommerce/shipping prepress2$ patch -b < shipping-settings.patch
patching file shipping.module
Reversed (or previously applied) patch detected! Assume -R? [n] y
Hunk #1 succeeded at 16 with fuzz 2 (offset 8 lines).
Hunk #2 FAILED at 124.
1 out of 2 hunks FAILED -- saving rejects to file shipping.module.rej

Any help would be helpful.

Thanks,
David

#10

tknospdr - March 26, 2008 - 14:04

Anyone out there?

#11

JohnAlbin - March 26, 2008 - 20:43

Nope. See #6 and #7 above. :-(

#12

djmystic82 - September 12, 2008 - 11:31

SHould this patch work for 5.x.3.4? I have applied it but still get the "Mail template for ec_mail_shipping_notification could not be found!" error message.

#13

pwhite - September 25, 2008 - 09:44

I'm having the same problem - when you click the notify shipping in 3.5 nothing happens - any ideas?

#14

enli - October 12, 2008 - 22:59

Subscribing. Patch not working in 3.5

#15

djmystic82 - October 16, 2008 - 08:57

NOt sure if this is worth mentioning, but I realised you have to have the shipping api module enabled for the shipping notify template to appear on 5.x.3.4

#16

enli - October 23, 2008 - 09:08

Yes in fact it is enabled but emails can't be sent via ecommerce management.

#17

carole - November 1, 2008 - 16:37

I'm running ec3.4, and I've got a few issues.

1) I cannot send shipping notifications, same issue as in this thread. Shipping API is installed & config'd. I would need more details to apply the patch to ec3.3 which is in this thread, it since it's not even clear to me which is the old string, which is the new one, and the code lines don't match.

2) Secondly, my taxes won't apply. I get the Canada-wide one to work, but not provincial ones. I used the same set up, I would love help fixing this. Also, I don't have a dropdown for provinces - that would be helpful. It seems EC Region module will be helpful here, but I haven't tried it yet.

3) Can someone please help me with a code snippet to load "store/history" in a block on my custom "cancel payment" page? Otherwise I'll end up with old pending orders.

Thanks a lot. I'm almost done EC config, I think, and I'm really anxious to go live.

#18

pwhite - November 11, 2008 - 11:06

I fixed the problem with it not sending shipping emails.

1. I enabled the shipping api module.
2. I changed

'callback arguments' => array('store_transaction_mail_form', arg(4), t('Shipping notification'), MAILVAR_SHIP_NOTICE),

to

'callback arguments' => array('store_transaction_mail_form', arg(4), t('Shipping notification'), ECMAIL_TYPE_SHIP_NOTICE),

For me this was on line 62 of shipping.module.

I believe this is fixed on newer versions.

#19

carole - November 14, 2008 - 18:58

Phil,
Thank you, that fixed my problem. However, I had it on EC3.4 and 3.5. I don't understand why it wasn't already fixed in those versions, the thread says it was. A module maintainer should look into this.

#20

JohnAlbin - November 16, 2008 - 16:38
Assigned to:brmassa» Anonymous

Because the maintainers have not been supporting ec3.x for over a year and a half (possibly longer). See comment #7 above. There should be a big warning on project homepage about this, but there isn't one.

ec3 is not supported. Known bugs (since June 2007) have not and will not be fixed.
ec4 is supported but is only alpha-level-quality code.

See: “eC Development: DEATH” http://groups.drupal.org/node/11898
and: #189546: Why have you set the alpha version as the current 5.x release

#21

carole - November 30, 2008 - 01:42

I had terrible problems with shipping not working. I could never get past the "choose shipping method" screen with canada post - no options were ever displayed, and to avoid that bug, I turned off shipping api.

Now I can't manually set transaction statuses to "shipped" and send emails. I have a default shipping notification configured, and I applied this patch, but once I turned off shipping api when I click "shipped," the delay makes me believe something is happening, but the status does not update and the email is not sent. It's going to be difficult to track shipped orders. Does anyone have a work around?

 
 

Drupal is a registered trademark of Dries Buytaert.