I just found a lot of notices on the admin page and on the specific webform page's generate pdf tab.

I seems there are a lot of unhandled variable which have no values.

CommentFileSizeAuthor
#1 webform2pdf_default_variable_handling-1625246-1.patch40.5 KBdenes.szabo
webform2pdf-admin-settings-notices2.png37.26 KBdenes.szabo
webform2pdf-admin-settings-notices.png262.49 KBdenes.szabo

Comments

denes.szabo’s picture

denes.szabo commented
Status: Active » Needs review
StatusFileSize
new webform2pdf_default_variable_handling-1625246-1.patch40.5 KB

Here is my patch to solve this problem. I added two helper function for handling default values in the setting forms. These keep easiest managing form default values and reduces the code complexity. You can add default value to every form elements you want.

(Unfortunately git apply do not apply the patch for me, I could not find the problem but everything seems fine. With patch -p1 < patch I could apply the patch flawlessly.)

mr.york’s picture

mr.york commented
Status: Needs review » Closed (cannot reproduce)