This is a backport of the patch at http://drupal.org/node/129805

We have been testing this on a development site for about a week and a half and no problems have been found.

Comments

gnat’s picture

StatusFileSize
new11.04 KB

Your patch was giving me an error of a call to an undefined function for

buddylist_confirm_form();

I grabbed that function from the Drupal 5 version of the module, and it now works as expected. Here's the updated patch.

gnat’s picture

StatusFileSize
new11.19 KB

There was a bug in my last patch that was giving a nasty error when you tried to deny a buddy request.

Fatal error: Unsupported operand types in /site_dir/new/includes/form.inc on line 88

There were two things causing this. One was a call to "drupal_get_form" in the menu callback for the deny function, this had been addressed in the patch for accept already, so I used the same method:

        //'callback' => 'drupal_get_form',
        //'callback arguments' => array('buddylist_pending_requested_deny',$id),
        'callback' => 'buddylist_pending_requested_deny',
        'callback arguments' => array($id),

The other reason was a form id for the confirmation form:

  $output = confirm_form(
+    'buddylist_pending_requested_accept',
    buddylist_confirm_form($requester_account, $requestee_account),
    t('Accept Request'),
    'buddylist/'.$requestee_uid.'/buddies/requests',
    t("Are you sure you want to deny the request from !name?", array('!name' => theme('username', $requester_account))),
    t('Yes'), t('No'),
    'buddylist_request_deny_confirm');
  return $output;
}

This patch reflects those changes.

simon georges’s picture

Status: Needs review » Closed (won't fix)

This version of Buddylist is not supported anymore. The issue is closed for this reason.

Please upgrade to a supported version and feel free to reopen the issue on the new version if applicable.