Add Migrate support to 'Physical Fields'

Do you use the Migrate module? Feeds-module integration works fine with this patch: #1372070: Integrate with Feeds (Patch Ready)

For the physical_weight field use this class as fieldHandler arguments :

class MigrateCommercePhysicalWeightFieldHandler extends MigrateFieldHandler {
  public function __construct() {
    $this->registerTypes(array('physical_weight'));
  }

  static function arguments($unit = NULL) {
    $arguments = array();
    if (!is_null($unit)) {
      $arguments['unit'] = $unit;
    }
    return $arguments;
  }

  public function prepare($entity, array $field_info, array $instance, array $values) {
    $migration = Migration::currentMigration();
    $arguments = (isset($values['arguments']))? $values['arguments']: array();
    $language = $this->getFieldLanguage($entity, $field_info, $arguments);
    // Setup the standard Field API array for saving.
    $delta = 0;
    foreach ($values as $value) {
      $unit = isset($arguments['unit']) ? $arguments['unit'] : 'kg';

      $return[$language][$delta]['weight'] = $value;
      $return[$language][$delta]['unit'] = $unit;
      $delta++;
    }
    if (!isset($return)) {
      $return = NULL;
    }
    return $return;
  }
}

use with:

    $weight_field_arg = MigrateCommercePhysicalWeightFieldHandler::arguments('kg');
    $this->addFieldMapping('field_weight', 'weight')
    ->arguments($weight_field_arg);

for the Physical dimensions field use this fieldHandler

class MigrateCommercePhysicalDimensionsFieldHandler extends MigrateFieldHandler {
  public function __construct() {
    $this->registerTypes(array('physical_dimensions'));
  }

  static function arguments($unit = NULL) {
    $arguments = array();
    if (!is_null($unit)) {
      $arguments['unit'] = $unit;
    }
    return $arguments;
  }

  public function prepare($entity, array $field_info, array $instance, array $values) {
    $migration = Migration::currentMigration();
    $arguments = (isset($values['arguments']))? $values['arguments']: array();
    $language = $this->getFieldLanguage($entity, $field_info, $arguments);
    // Setup the standard Field API array for saving.
    $delta = 0;
    foreach ($values as $value) {
      if (is_array($value)) {
        $unit = isset($arguments['unit']) ? $arguments['unit'] : 'cm';

        $return[$language][$delta]['length'] = $value['length'];
        $return[$language][$delta]['height'] = $value['height'];
        $return[$language][$delta]['width'] = $value['width'];
        $return[$language][$delta]['unit'] = $unit;
        $delta++;
      }
    }
    if (!isset($return)) {
      $return = NULL;
    }
    return $return;
  }
}

use with :

$dimensions_field_arg = MigrateCommercePhysicalDimensionsFieldHandler::arguments('cm');
    $this->addFieldMapping('field_dimensions', 'dimensions')
    ->arguments($dimensions_field_arg);

in prepareRow migrate method i prepare the dimensions row value:

    $row->dimensions = array('length' => $row->depth, 'width' => $row->width, 'height' => $row->height);

and don't forget to add 'dimensions' to source_fields argument of MigrateSource

See also #1671108: Support for physical_weight field - one of these should be marked a dupe of the other. The other issue has the advantage of having a patch...

I tried this and weight worked perfectly, but dimensions wasn't working. I updated it based on code from addressfield and it seems to be working now.

Here's an updated patch with subfield support. Marking the other as a dupe

Tested and works

Updated patch using subfields for dimensions. Length is the dimension key and weight is the weight key.

better title for my dashboard.

New patch, based on #10, but:

• Patch against physical instead of migrate_extras.
• Field handlers are in includes/migrate sub folder.
• Add example in the comment for each handler.
• Use sub fields (arguments are possible, too) for all dimensions.

Tested with all the 3 dimensions and the weight field. But I'm not going to RTBC my patch.

The patch in #12 is not working, if you have a single value field and no values on the entity.

I made a new patch.

I was going to ask a question about the behavior of the patch I was seeing, but in the process of writing my question, I discovered the source of my problem. (Applying the patch to Commerce Kickstart's profile structure did not go as error-free as I'd thought.) I've now got it working, and it appears to be working smoothly for me.

So, instead I'd just like to thank you all for the work you put into this patch! It's quite useful and I hope it gets approved and implemented.

If you want this patch to be commited, set the status to reviewed.

How much authority does it take to set the status to reviewed? I can say that the patch is working for me, but I'm not exactly the right person to tell whether it meets Drupal's coding standards.

#13 works great, thanks.

#13 also worked for me.

Committed, thanks.