I use a node title as a part of node alias.

Current pattern is:

catalog/[node:content-type:machine-name]/[node:title]

When node title contain the single quote symbol, the alias of node build on catalog/[node:content-type:machine-name] pattern, and does not contain node title.

How to fix this bug?

CommentFileSizeAuthor
#12 interdiff_10-12.txt705 byteszestagio
#12 pathauto-single_quote_breaks_an_alias-1626990-12-D7.patch852 byteszestagio
#10 pathauto-single_quote_breaks_an_alias-1626990-10-D7.patch852 byteszestagio
#7 pathauto-fix-htmlchars-1626990-7.patch464 byteschadedge
#4 pathauto-fix-htmlchars-1626990-3.patch482 byteschadedge
#3 pathauto-fix-htmlchars-1626990-3.patch483 byteschadedge

Comments

sun-fire’s picture

sun-fire commented

UPD:

How to reproduce this bug: node title must have < > symbols and quote.

For example (cyrillic text):

<М'ЯТА УПАКОВКА> Роутер D-Link DIR-100 1port WAN

Transliteration return:

Router D-Link DIR-100 1port WAN

When i removed < > and ' all works as designed.

When i removed < it also works as designed

When string contain ' and > it does not working.

emclaughlin’s picture

emclaughlin commented

So, if I understand what you're saying correctly, when you create a node titled "МЯТА УПАКОВКА Роутер D-Link DIR-100 1port WAN" the alias that gets assigned to it is "node/МЯТА УПАКОВКА Роутер D-Link DIR-100 1port WAN" and when you create a node titled "<М'ЯТА УПАКОВКА> Роутер D-Link DIR-100 1port WAN" the alias that gets assigned to it is "node/"?

Or does it not get an alias assigned to it at all? I'm attempting to reproduce the problem and finding that "<М'ЯТА УПАКОВКА> Роутер D-Link DIR-100 1port WAN" doesn't get an alias assigned to it at all through pathauto.

chadedge’s picture

chadedge commented
Title: Single quote breaks an alias » Single quote breaks an alias (strip html)
Issue summary: View changes
StatusFileSize
new pathauto-fix-htmlchars-1626990-3.patch483 bytes

I was having a similar issue where users were adding <3 (emoticon for a "heart") into the title of their posts. This caused the strip_tags to eliminate the entire title string (returning an empty string) so the path auto could not generate a URL alias.
By swapping decode_entities() and strip_tags() I was able to eliminate this issue.

-- This patch is now outdated. #4 is the correct patch (trying to delete this commit) --

chadedge’s picture

chadedge commented
Version: 7.x-1.1 » 7.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new pathauto-fix-htmlchars-1626990-3.patch482 bytes
chadedge’s picture

chadedge commented

Status: Needs review » Needs work

The last submitted patch, 4: pathauto-fix-htmlchars-1626990-3.patch, failed testing.

chadedge’s picture

chadedge commented
StatusFileSize
new pathauto-fix-htmlchars-1626990-7.patch464 bytes

Attempting to resubmit patch using more updated branch of 7.x-1.x pathauto.

chadedge’s picture

chadedge commented
Version: 7.x-1.x-dev » 7.x-1.1
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 7: pathauto-fix-htmlchars-1626990-7.patch, failed testing.

zestagio’s picture

zestagio commented
Status: Needs work » Needs review
StatusFileSize
new pathauto-single_quote_breaks_an_alias-1626990-10-D7.patch852 bytes

I confirm a bug. I have a term with name "<200 mm Dia Flap wheel". Alias is empty after processing string via pathauto_cleanstring.

Patch attached.

Status: Needs review » Needs work

The last submitted patch, 10: pathauto-single_quote_breaks_an_alias-1626990-10-D7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

zestagio’s picture

zestagio commented
Status: Needs work » Needs review
StatusFileSize
new pathauto-single_quote_breaks_an_alias-1626990-12-D7.patch852 bytes
new interdiff_10-12.txt705 bytes

Status: Needs review » Needs work

The last submitted patch, 12: pathauto-single_quote_breaks_an_alias-1626990-12-D7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

zestagio’s picture

zestagio commented
Status: Needs work » Needs review
mably’s picture

mably commented
Status: Needs review » Closed (outdated)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.