The menu item for the content overview screen points to /admin/content, which is not accessible if only the 'Access the content overview page' is granted. This means that if user's only have that permission, the only way they can access the page is by typing in a direct link to /admin/content/node, since this is the path that user's are granted access to if they have that permission.

CommentFileSizeAuthor
#3 1627020.patch863 bytesdamiankloip
#1 1627020-admin_views-content-overview-permission.patch1.13 KBmrfelton

Comments

mrfelton’s picture

mrfelton commented
Status: Active » Needs review
StatusFileSize
new 1627020-admin_views-content-overview-permission.patch1.13 KB

I think it's just a permissions issue. The views access permissions defined for the /admin/content path should be as per node.module. Patch attached.

Status: Needs review » Needs work

The last submitted patch, 1627020-admin_views-content-overview-permission.patch, failed testing.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new 1627020.patch863 bytes

Ok, so we should change this to the 'access content overview' permission, as this is what is used for this page in the node module.

mrfelton’s picture

mrfelton commented

Yes, which is what my last patch did. But you have difference in the description of the menu item. The menu item should be same as the one that core provides, which has the description of "Find and manage content.", not "View, edit, and delete your site\'s content.". That was from Drupal 6 I think.

damiankloip’s picture

damiankloip commented

Ok, makes sense. Thank you.

damiankloip’s picture

damiankloip commented

#1: 1627020-admin_views-content-overview-permission.patch queued for re-testing.

damiankloip’s picture

damiankloip commented

Sorry, I guess I was being stupid ;)

I have queued your patch for re-testing, as I don't think it failed because of the patch last time.

damiankloip’s picture

damiankloip commented

Actually, I think you are referring to the view description and not a menu item. The system style plugin in admin_views just overrides what is at a system path, it doesn't declare any menu descriptions etc...

So the patch in #3 is probably good.

mrfelton’s picture

mrfelton commented
Status: Needs review » Reviewed & tested by the community

Both patches have passed. Lets get one of these committed!

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

I'm fine with #1. The view descriptions were originally supposed to equal the menu item descriptions.

That said, I'd like to see a follow-up issue to investigate why we're overriding the access permissions in the first place. I'd somehow expect that the system display handler only replaces the page content, and nothing else. That's a larger issue though, and we can commit this stop-gap fix independently from that.

damiankloip’s picture

damiankloip commented
Status: Reviewed & tested by the community » Fixed

Ok, That's enough agreement for me :) Committed.

damiankloip’s picture

damiankloip commented

@sun, you also have a very good point regarding the access. This should be inherited from the current menu item. I have created an issue for this: #1697902: Access should be inherited from menu_item, not view access plugin.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.