Is there anything gained from making the pager.inc pager pieces themeable? I'm no longer sure, but the attached patch does so.

CommentFileSizeAuthor
#7 pager.inc_5.patch3.54 KBjeremy
#6 pager.inc_4.patch3.54 KBjeremy
#5 pager.inc_3.patch8.85 KBjeremy
#2 pager.inc_2.patch8.63 KBjeremy
pager.inc_1.patch8.65 KBjeremy

Comments

Bèr Kessels’s picture

Bèr Kessels commented

great! +1 from me.

But, the three dots (...) are still not thmeabnle, nor have they got a style. The arent even wrapped in a HTML element. IMO that we sthe worst thing of the current pager: that i could do nothing with these dots. :)

jeremy’s picture

jeremy commented
StatusFileSize
new pager.inc_2.patch8.63 KB

Is it sufficient to wrap them in div? See attached.

tangent’s picture

tangent commented

Wrapping them in a div is only marginally better for theming purposes without assigning a class.

dries’s picture

dries commented

Committed to HEAD.

jeremy’s picture

jeremy commented
StatusFileSize
new pager.inc_3.patch8.85 KB

Here's a followup patch to add classes to each of the pager pieces, and the "...".

jeremy’s picture

jeremy commented
StatusFileSize
new pager.inc_4.patch3.54 KB

Here's the proper followup patch.

jeremy’s picture

jeremy commented
StatusFileSize
new pager.inc_5.patch3.54 KB

Sorry for the shotgun effect, but rumor has it you should close quotes. One more patch attached.

dries’s picture

dries commented

Committed to HEAD.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Dries committed the patch without the closed quotes!

dries’s picture

dries commented

Committed to HEAD.

Anonymous’s picture

(not verified) commented