Problem/Motivation

Currently geocoder uses a custom approach for handling visibility of dependent fields. Other modules cannot easily modify or extend the visibility settings, e.g., to set an additional visibility condition.

Proposed resolution

Convert the code to use the standard Drupal 7 #states system.

Remaining tasks

CommentFileSizeAuthor
#6 use-states-followup-1627908-6.patch3.9 KBnedjo
#2 use_states-1627908-2.patch4.88 KBplopesc

Comments

phayes’s picture

phayes commented

I'm not familiar with the new #states system nedjo. I'll give it a shot, but if you have a patch up your sleeve... :-)

~Patrick

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Active » Needs review
StatusFileSize
new use_states-1627908-2.patch4.88 KB

Patch attached

now it could work with '#states'

Regards

phayes’s picture

phayes commented
Status: Needs review » Fixed

Commited. Thanks Nedjo

phayes’s picture

phayes commented

Errrr, I meant, "Thanks plopesc"

phayes’s picture

phayes commented

Errrr, I meant, "Thanks plopesc"

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Fixed » Needs review
StatusFileSize
new use-states-followup-1627908-6.patch3.9 KB

Dependent fields aren't being updated after geocoder_handler changes. Attached patch triggers .change() to fix this.

Also tweaks the admin js to more closely follow Drupal js conventions:

  • Use .once() when applying behaviour.
  • Use :input selector rather than # to be AJAX safe (IDs may change).
  • Attach using .change() rather than onupdate.
phayes’s picture

phayes commented
Status: Needs review » Fixed

committed. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.