There are a lot of db_query() calls in the code from my initial Drupal 7 port.

Those should be converted to db_select. I believe all insert/update SQL already uses db_insert and db_update.

Comments

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Title: Cleanup: Use DBTNG entirely » Cleanup: Use DBTNG properly

This is actually not true, and the opposite should be done for simple queries (which is basically all of mine). There is a performance hit using db_select, though I assume it's minor.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Issue tags: +fillpdf2

This is part of the refactor.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 7.x-2.x-dev » 8.x-4.x-dev
Issue summary: View changes
Issue tags: -fillpdf2