I took a hammer to poll module. I've done the following things:
- Fixed E_NOTICE errors.
- Fixed all of the forms to conform both to new documentation and new FAPI. These forms now behave wonderfully. There's a pleasant side effect to the way I did this change: Voting or cancelling a vote on a poll no longer takes you to the poll page, but leaves you on whatever page you were on. This is very nice if you're looking at a list of polls or voting on a poll in a block, where it's disconcerting to be taken to a different page, usually.
- Made all of the theme functions comply with new .tpl.php standards and documentation.
- Re-organized the code logically. The functions in this module were spread in places that simply didn't make sense.
This effort came out of an earlier effort to add a new UI to the poll.module; on Steven's advice I've backed that part out of this, because it's a pretty sweeping change and fairly late in the D6 process to get that in. The rest of this, IMO, is necessary. The code must be kept up to date.
|poll.fixes_.patch||32.46 KB||Ignored: Check issue status.||None||None|