Missing thumbnails and regenerated images on every page view

I had a problem and figured out the fix. Symptoms were, after updating this module (upload_image-5.x-1.x-dev, from 1.17.2.2 to 1.17.2.3) and image.module (image-5.x-1.1 to image-5.x-1.4), uploaded image thumbnails disappeared from the bottom of the parent node views, and every page view included the message "The image Test Picture had missing derivative image which has been regenerated." -- for every uploaded image on it.

The problem is that this version of upload_image is storing the image derivative label (i.e., "Custom") in the variable table instead of the lower-case size ("custom") version of it. So when upload_image invokes image_display it can't find the right size, tries to regenerate everything, and passes nothing back. (This doesn't seem to have changed since the last version, so I don't know why it wasn't broken then, too; change in image.module, maybe?)

The fix is simply to make the admin page fill the "Upload image size" pulldown with 'size=>label' pairs instead of 'label=>label' pairs by changing (in this version) line 47 from

  $options[$field['label']] = $field['label'];

to:

  $options[$size] = $field['label'];

Then you have to go to the image admin page, select the correct image upload size again, and submit the form. Note that you will see the the image-regenerated notice one more time for every image (since you changed the image settings), but after that everything should work fine.