According to this recommendation -
all theme calls should now use one array parameters
- I think we should adapt the call to theme('freelink_error') to new conventions.
at this time the call is implemented as:
function freelinking_get_freelink($plugin, $target, $format = 'all', $rendered = TRUE) {
...
theme('freelink_error', array($plugin, $link['message']));
...
}
We should change it to:
function freelinking_get_freelink($plugin, $target, $format = 'all', $rendered = TRUE) {
...
theme('freelink_error', array('plugin' => $plugin, 'message' => $link['message']));
...
}
So the message will be available inside of hook implementation:
function theme_freelink_error($variables) {
$plugin = $variables['plugin'];
$message = $variables['message'];
...
}
Comments
Comment #1
ruslan.muradov commentedAnd here is the patch that I made for that issue
Comment #2
ruslan.muradov commentedComment #3
gregglesMakes sense to me. I looked for other invocations of this function in the module and didn't find any. The .module file already expects parameters in this format http://drupalcode.org/project/freelinking.git/blob/refs/heads/7.x-3.x:/f...
I'd mark RTBC but didn't test myself and don't want to overstep.
Comment #4
juampynr commentedCommitted. Many thanks!
http://drupalcode.org/project/freelinking.git/commitdiff/1fb07a6
Comment #5.0
(not verified) commentedChanges to Description content