According to this recommendation -

all theme calls should now use one array parameters

- I think we should adapt the call to theme('freelink_error') to new conventions.

at this time the call is implemented as:

function freelinking_get_freelink($plugin, $target, $format = 'all', $rendered = TRUE) {
  ...
  theme('freelink_error', array($plugin, $link['message']));
  ...
}

We should change it to:

function freelinking_get_freelink($plugin, $target, $format = 'all', $rendered = TRUE) {
  ...
  theme('freelink_error', array('plugin' => $plugin, 'message' => $link['message']));
  ...
}

So the message will be available inside of hook implementation:

function theme_freelink_error($variables) {
  $plugin  = $variables['plugin'];
  $message = $variables['message'];
  ...
}
CommentFileSizeAuthor
#1 freelinking-1630020-1.patch580 bytesruslan.muradov

Comments

ruslan.muradov’s picture

StatusFileSize
new580 bytes

And here is the patch that I made for that issue

ruslan.muradov’s picture

Status: Active » Needs review
greggles’s picture

Makes sense to me. I looked for other invocations of this function in the module and didn't find any. The .module file already expects parameters in this format http://drupalcode.org/project/freelinking.git/blob/refs/heads/7.x-3.x:/f...

I'd mark RTBC but didn't test myself and don't want to overstep.

juampynr’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Changes to Description content