In every text field the " character will be displayed as " . In the source the " was " too, but after syndication in the Drupal site it's wrong.
Example: http://www.inforo.net/curso_quot_aproximacion_historia_fotografia_quot_e...

Comments

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Active » Needs work

It's only a problem at parser_simplepie, so I did the following:
diff simplepie.inc ~/SimplePie\ 1.0.1/simplepie.inc

7493c7493
<                       $full .= " $key=\"" . $value['data'] . '"';
---
>                       $full .= " $key=\"" . htmlspecialchars($value['data']) . '"';
9474c9474
<        * @version CVS: $Id: simplepie.inc,v 1.1.2.1 2007/07/30 07:39:06 aronnovak Exp $
---
>        * @version CVS: $Id: Validate.php,v 1.104 2006/11/17 16:32:06 amir Exp $
10406c10406
<                                               $this->data['data'] .= ' ' . $name . '="' . $value . '"';
---
>                                               $this->data['data'] .= ' ' . $name . '="' . htmlspecialchars($value, ENT_COMPAT, $this->encoding) . '"';
10429c10429
<                       $this->data['data'] .= $cdata;
---
>                       $this->data['data'] .= htmlspecialchars($cdata, ENT_QUOTES, $this->encoding);
10773a10774,10778
>                       if ($type & (SIMPLEPIE_CONSTRUCT_TEXT | SIMPLEPIE_CONSTRUCT_IRI))
>                       {
>                               $data = htmlspecialchars($data, ENT_COMPAT, 'UTF-8');
>                       }
>

It's not an optimal solution because i had to modify SimplePie's code, but works and i committed.

budda’s picture

budda
Primary language English
Location Cheshire
commented

Since Simplepie is no longer distributed from Drupal CVS, whats the alternative fix to this issue?

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Needs work » Postponed (maintainer needs more info)

Well, i installed SimpleFeed to test the feed with another module uses SimplePie, but the feed mentioned in the first comment is unavailable.
I get another feed which contains " sign: http://rss.icerocket.com/xmlfeed?id=7118
The " sign remains good in both SimpleFeed and FeedAPI.
I would like to ask the bug reporter to tell me another feed(s) which reproduces this error to provide a chance for me to fix. (and test it with another simplepie-dependent aggregator module)

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented

I found an example feed that causes this issue: http://objectmodels.blogspot.com/feeds/posts/default
I fixed the problem for this feed (the solution is from SimpleFeed, thanks :) )
If someone experience this again, please reopen the ticket with an exact feed URL to reproduce this.

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Postponed (maintainer needs more info) » Fixed
drupalista’s picture

drupalista commented
Status: Fixed » Active

Sorry if this is the wrong place to report, I still do not completely understand the dev infrastructure of drupal...

I did a grep in drupal 6 beta1 and could not find the string simplepie, so I reopen this ticket as this error still occurs in drupal 6 beta 1.

You can check it out with the news.google.com RSS feed for Venezuela:
http://news.google.com/news?ned=es_ve&output=rss

The spanish rss feeds for some reason quite often have quotes, so you could also take Mexico or Cuba and wait a few days, but the day I am writing this there is one in Venezuela News RSS ("Reforma facilitará...").

Thanks!

drupalista’s picture

drupalista commented

BTW: also the pictures of news.google.com rss feeds are not shown, I am not yet quite sure if this is a bug or if something is wrong on my side, but there should be pictures with google news rss feeds...

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Active » Fixed

drupalista,
Sorry, Drupal-6 has been not supported yet. I plan to port it soon. (beginning of November?)
I tested the feed what you mentioned at Drupal 5 and i have not found problem at all.
Please notice: you have to download simplepie separately. For details please read the readme in the downloadable package.
About images: it's a missing feature. It's not a bug, but i have to admit that it can be annoying :) It has a ticket already (feed element mapper so please do not open another one for this)

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)