The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.{commerce_tax_rate}.description field is non nullable and has no default value, which means that when doing mass insertion of data in an install profile, we have to put an empty string for this field.
{commerce_tax_rate}.display_title could be nullable too, but at least it has a default value.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | commerce-commerce_tax_rate-1630112-4.patch | 780 bytes | wesleydv |
Comments
Comment #1
rszrama commentedLooks like a bit of copy/paste from the Node module's {node_type}.description. I don't see any reason not to supply a default value of '' for these columns, but I'll run it by Damien to make sure we're not introducing problems... my hunch is that since these were typically created via the UI, we always had the empty string coming from the submit form. We definitely want to support direct inserts, but at least the workaround is simple in the meantime. : D
Comment #2
pounardYes of course, nothing really urgent here, but it would be a good cleanup IMHO.
Comment #3
rszrama commentedTagging.
Comment #4
wesleydv commentedPatch.
Comment #5
rszrama commentedAs "not null", these shouldn't have a default value, and we needed an update function. Thanks for the first pass, final patch linked below.
Commit: http://drupalcode.org/project/commerce.git/commitdiff/b44211d