taxonomy_get_vocabularies needs static caching
robertDouglass - July 29, 2007 - 20:57
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | taxonomy.module |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | duplicate |
Description
This is an API function but if you use it you risk duplicating queries + processing. This patch adds static caching.
<?php
function taxonomy_get_vocabularies($type = NULL) {
+ static $vocabularies_cache = array();
+ static $vocabularies_null;
+
if ($type) {
+ if (is_array($vocabularies_cache[$type])) {
+ return $vocabularies_cache[$type];
+ }
$result = db_query(db_rewrite_sql("SELECT v.vid, v.*, n.type FROM {vocabulary} v LEFT JOIN {vocabulary_node_types} n ON v.vid = n.vid WHERE n.type = '%s' ORDER BY v.weight, v.name", 'v', 'vid'), $type);
}
else {
+ if (is_array($vocabularies_null)) {
+ return $vocabularies_null;
+ }
$result = db_query(db_rewrite_sql('SELECT v.*, n.type FROM {vocabulary} v LEFT JOIN {vocabulary_node_types} n ON v.vid = n.vid ORDER BY v.weight, v.name', 'v', 'vid'));
}
@@ -695,7 +704,15 @@ function taxonomy_get_vocabularies($type
$vocabularies[$voc->vid] = $voc;
}
+ if ($type) {
+ $vocabularies_cache[$type] = $vocabularies;
+ }
+ else {
+ $vocabularies_null = $vocabularies;
+ }
+
return $vocabularies;
+
}
?>| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| taxonomy_get_vocabularies_cache.patch | 1.48 KB | Ignored | None | None |
#1
I looked through this patch and everything looks good. I agree this should be cached. The only thing I wasn't sure of was the variable name $vocabularies_null, which as I understand it, gets set if a type isn't specified.
What about $vocabularies_all or something like that? Maybe someone else with a weightier opinion can give an opinion and change the patch code status.
Attaching a patch rolled against latest HEAD without offsets.
#2
patch still applies with offset...
#3
Is there a or two modules out thee that calls this function repeatedly? Just want some justification for the cache.
#4
grep -R taxonomy_get_vocabularies . | wc -l244
that's on the D5 contrib repository. Rerolled patch to apply without offsets.
#5
Still valid in D7.
We should go the whole hog and change this to taxonomy_vocabulary_load_multiple() so that hook_taxonomy_vocabulary_load() works with it and we can share the static between taxonomy_get_vocabulary() too.
#6
taxonomy_vocabulary_load_multiple() is in.