I am writing issue followups as comments and nodeapi changes title but because we set the page title before this change, it does not show. I am close to mark this as critical.

CommentFileSizeAuthor
title_cant_be_changed.patch489 byteschx

Comments

chx’s picture

chx commented

Five as well.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work

Please provide a better explanation. Why do you want to change the title? What do you want to change it to and why? What is the title instead? This sort of information helps me validate this patch. Thanks.

dmitrig01’s picture

dmitrig01 commented
Priority: Normal » Critical
Status: Needs work » Reviewed & tested by the community

Please provide a better explanation.

I'll do my best :)
sorry if I'm too verbose

Why do you want to change the title?

Dunno, but module X may want to change the title during the 'alter' op of nodeapi.
Currently, it can't do that.

What do you want to change it to and why?

Change Drupal to being able to have modules change the title on hook_nodeapi op='alter'.
It's a stupid mistake, it should have always been the way chx patched it to be.

What is the title instead?

The title is what it was, before nodeapi op=alter, even if that changed the title

chx’s picture

chx commented

As said, I am writing issue followups as comments. When you are changing an issue title then the node title changes and so should the page title but this is impossible without my patch because the node title changes during nodeapi indeed.

chx’s picture

chx commented
Status: Reviewed & tested by the community » Closed (won't fix)

Eaton says that this would mean that if you do a drupal_set_title in nodeapi that gets overridden and that's worse than needing an explicit drupal_set_title , so there.