Closed (fixed)
Project:
Drupal core
Component:
base system
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
27 Jan 2005 at 17:09 UTC
Updated:
4 Jun 2005 at 11:59 UTC
Jump to comment: Most recent file
Drupal emits an annoying number of PHP notices. The attached patch fixes a few of them in tablesort.inc.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | warning.patch | 2.45 KB | killes@www.drop.org |
| #5 | user-notices.patch | 8.18 KB | killes@www.drop.org |
| #2 | tablesort-notices_0.patch | 3.16 KB | killes@www.drop.org |
| tablesort-notices.patch | 3.42 KB | killes@www.drop.org |
Comments
Comment #1
Uwe Hermann commentedThe patch looks broken, there's Email-Headers included (probably erroneously cut'n'pasted there?)...
Comment #2
killes@www.drop.org commentedOops, thanks.
Comment #3
dries commentedCommitted to HEAD.
Comment #4
killes@www.drop.org commentedHere is another one for user.module. I unified the return value for user_load and user_external_load to both return an otherwise empty user object with uid = 0.
Comment #5
killes@www.drop.org commentedand the patch...
Comment #6
dries commentedIt doesn't exactly make the code easier to read ...
Comment #7
killes@www.drop.org commentedWhich parts? Maybe you can apply the chunks you like and leave the others for a second try.
Comment #8
buddaWhen caching is turned on, PHP Notice is generated in the drupal_set_message() function.
The Return line needs to be amended to consider the fact that there might not be an array index available.
return isset($_SESSION['messages']) ? $_SESSION['messages'] : NULL;
Comment #9
killes@www.drop.org commentedThe patch against user.module is still valid.
We should have general guidelines about whether to care for notices or not.
Comment #10
killes@www.drop.org commentedOk, here is a smaller patch which gets rid of a large number of notices.
Comment #11
dries commentedCommitted to HEAD. Thanks.
Comment #12
(not verified) commented