By ñull on

I made patch for something my client finds very important. It does not affect the working of Drupal, it only makes it more configurable. With every upgrade of Drupal I would need to apply it again unless it is included in the head. I submitted it here: http://drupal.org/node/16299. Is this the right place that it would be included in the head? I don't have CVS access. Would small patches like this justify CVS access?

Comments

killes@www.drop.org’s picture

killes@www.drop.org commented

You won't get CVS write access for the main Drupal repository. Only four people have it and of those only two regularly use it.

Your patch is incomplete, there is no admin interface to change the setting. Also, we try not to include "yet another option". i think the right way would be to make the format_name function themable.
--
If you have troubles with a particular contrib project, please consider filing a support request. Thanks. And, by the way, Drupal 4.5 does not work with PHP 5.

--
Drupal services
My Drupal services

ñull’s picture

ñull commented

I don't think it is important enough to have yet another setting in admin. I just followed the example of userposts.module where you find a configurable number of userpost through the variable 'profile_list_amount' and it cannot be set in admin. It is just a good compromise between too much and not enough.

I am not working with PHP5 (yet).

boris mann’s picture

boris mann commented

Without looking at the patch, I don't know what it does. The general process is to create a feature request or bug report, describing what your patch does, and attaching the patch.

Developers and users then review/comment on the patch, and core maintainers will consider those comments and the code to decide whether or not to include the patch.

So, start by following that process. Getting on the developer mailing list would also be helpful.