Search Submit Button Text

Hi,

I think your module is too short.
Don't specify the "version" information in the ".info", the drupal.org system will specify it.

You don't declare the hook_perm() which must indicate your administer search_page_submit_button_text permission.
You have to indent too your code into all blocks (for example, on your if() instructions).
Don't forget the t() function on the line 13 of your search_page_submit_button_text_form.inc arround the Search page's text : l('Search page\'s','search/node')

You can use the ventral tool too in this URL : http://ventral.org/pareview and specify your git URL.
This tool is a very good way to know what's wrong in your module.

Regards,

Hi,

The project work correctly but the problem that is too short.

This url how much code do we need to approve a user? propose simple rules that can be used to deny the "create full projects" permission (everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed).

Hi,

When defining permissions in hook_perm is is not necessary and even nicer to not use underscores in the permission name. I'm not sure whether this are any Drupal guidelines about this, but I would recommend to change your implementation of hook_perm to the following (and of course update the permission references in your implementation of hook_menu):

function search_page_submit_button_text_perm() {
  return array('administer search page submit button text');
}

Furthermore, in order to make the code a bit more performant I would recommend to replace the 2 "if"-statements in function search_page_submit_button_text_form_alter with either an "if-elseif"-structure of with a switch structure. For example:

switch ($form_id) {
  case 'search_form':
    ...
  case 'search_theme_form':
    ...
}

And last but not least, I would recommend changing line 17 in file search_page_submit_button_text_admin_form.inc: you should use the t-function only once and use placeholders. So change line 17 to something like
t('Enter in the value for the !url submit button', array('!url' => l(t("Search page's"), 'search/node')));
That would be more meaningful to potential translators.

Hi Sjarsena,

I'm not sure that this module's use case is warranted to become a full fledged drupal project.

In my opinion, string manipulation should be handled by existing modules (e.g String Overrides), or handled on a site by site basis.

Cheers, Charlie.

Changing this to closed as all reviewers seem to agree it is too short to warrant full project status.

It is perfectly fine to have short projects as full projects. It just means that we can't give the git vetted user role away, but we can of course promote the project manually.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

There is still a master branch. Make sure to set a version specific branch and remove the "master" branch. See here for some instructions: http://drupal.org/node/1127732

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Update and fixed any issues with coding and the repo