Environment Details

PHP - 5.2.3
Apache - 2.2.3
Drupal - drupal-6.x-dev
OS - Linux (Fedora Core 6)

Reproducing Issue
------------------------
1 - Administer garland theme - http://www.testsite8.com/admin/build/themes/settings/garland
2 - Select a different color set (shiny tomato)
3 - Submit
on clicking the submit button it gives the following notices

* notice: Undefined property: stdClass::$stylesheet in /work/projects/testsites/drupal/6.x/testsite8/www/modules/color/color.module on line 282.
* notice: Undefined offset: 1 in /work/projects/testsites/drupal/6.x/testsite8/www/modules/color/color.module on line 293.

please see attached screenshot. Also notice the Shiny Tomato colors are not applied to the theme. Only the logo's background changes to the one specified for Shiny Tomato.

CommentFileSizeAuthor
#5 color-fix-switching-colors-163069-5.patch2.41 KBwebchick
#4 163069_2.patch1.33 KByasheshb
#2 163069_1.patch1.07 KByasheshb
Screenshot-2_1.png174.58 KByasheshb

Comments

steinmb’s picture

steinmb commented

Also get it in:
Clean install of Drupal6 dev 31.7.2007
MySQL: version: 4.1.20
PHP version: 4.3.9

Changing clolor in default Garland theme. The only thing that visually get cahanged is the background color on Drupal icon.

notice: Undefined variable: file in modules/color/color.module on line 224.
notice: Undefined property: stylesheet in modules/color/color.module on line 282.
notice: Undefined offset: 1 in modules/color/color.module on line 293.

yasheshb’s picture

yasheshb commented
Status: Active » Needs work
StatusFileSize
new 163069_1.patch1.07 KB

this is a partial fix... it does change the color scheme of the theme. but
there are still occasions where it gives the warning.

notice: Undefined variable: file in modules/color/color.module on line 224.

rgd.

yashesh bhatia.

steinmb’s picture

steinmb commented

YES!
It now changes the color, but it gives me (like you indicated):
notice: Undefined variable: file in /var/www/websites/tbsk/test/drupal6/modules/color/color.module on line 224.

--
SMB

yasheshb’s picture

yasheshb commented
StatusFileSize
new 163069_2.patch1.33 KB

hi..

this one fixes the "notice: Undefined variable: file in /var/www/websites/tbsk/test/drupal6/modules/color/color.module on line 224."
notice too.

thx
yashesh bhatia.

p.s - 163069_2.patch is a superset of 163069_1.patch

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: Administering Garland Theme gives php notice (warnings) and does not complete admin task » Switching colour schemes in color.module does not work
Status: Needs work » Needs review
StatusFileSize
new color-fix-switching-colors-163069-5.patch2.41 KB

Confirmed this fixes the problem of saving different colour schemes. There is still a notice about index 0 on line 33 of page.tpl.php. This patch adds in that final fix. This should be good to go now, but could use an extra set of eyes.

Also, upgrading status to critical, since it breaks functionality.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Priority: Normal » Critical
dvessel’s picture

dvessel commented

Isn't style.css optional now? Or would that be a requirement to get color.module working.

Maybe it should check for it also and disable itself if not found.

steinmb’s picture

steinmb commented

Downloaded 13 aug. the latest version of Drupal6. Changeing the colors works perfect now :)
Close this bug?

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Closed (fixed)

Confirmed. All the notices seem gone, too. Thanks, steinb! :)