Closed (fixed)
Project:
Views Slideshow Simple Pager
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
13 Jun 2012 at 09:07 UTC
Updated:
14 Mar 2017 at 22:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jenlamptonSome of this patch includes the jQuery added by Paul.B in the other issue, but that was not sufficient for me, I also had to make the items into links, so my mod's added as well.
Comment #2
bleen commentedthis is the identical patch as in #1 with some whitespace problems removed
Comment #3
anniegreens commentedI've discovered an issue with the use case where multiple items are shown on one slide, an option of Views Slideshow. The current implementation does not take this variable into account. So, for example, if this option is set with three (3) items per slide with a total of three (3) slides, the pager will output nine (9) items but only 1, 2, and 3 are actually clickable.
The attached patch includes changes to support this correctly, as well as the changes for the pager to be clickable from above.
Comment #4
anniegreens commentedNew patch using
l()for clickable pager andjavascript:void(0)instead of#to avoid page jump when clicking through pager.Comment #5
nickdickinsonwildeApplied patch to version in Views Slideshow 7.x-3.7