EMF CakeMail extends the E-mail Marketing Framework module to support the CakeMail mass mailing platform.

This module requires the E-mail Marketing Framework and a CakeMail API access.

git clone http://git.drupal.org/sandbox//garphy/1630866.git emf_cakemail_plugin

Comments

anwar_max’s picture

anwar_max
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Everything looks good.
Coding standards, proper use of t() functions for all the strings and proper use of sanitized function for all the user or admin submitted data.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

patrickd’s picture

patrickd commented
Status: Reviewed & tested by the community » Needs work
  • your package is a little too specific, isn't there a kind of category similar modules use?
  • all human readable string must be encapsulated by t()! eg. here: 'title' => 'Administer EMF CakeMail plugin configuration', (except within hook_menu(), hook_schema() and watchdog())
  • filtering default values is absolutely not necessary
    '#default_value' => check_plain(variable_get('emf_cakemail_api_key', '')),
  • if your using variables you got to delete them (by variable_del() within a hook_uninstall() in a .install file)
  • your using curl - but curl is no drupal requirement. you got to check for it in hook_requirements() in the .install file. Have a look at how other modules do this (eg. virustotal)

switching back to needs work, sorry not ready yet

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.