As part of the automated interface translation Locale module needs to import available languages from a translation server and download gettext files and import the included translations. This process can be derived from the import process as done by Localization Update module.

CommentFileSizeAuthor
#35 1632384-nr-bot.txt3 KBneeds-review-queue-bot
#32 interdiff_20-32.txt2.42 KBranjith_kumar_k_u
#32 1632384-32.patch5.68 KBranjith_kumar_k_u
#20 import_available_language_data-1632384-20.patch5.67 KBinternetdevels
#10 import-available-language-data-1632384-10-.patch5.65 KBsutharsan
#10 interdiff-9-10.txt1.46 KBsutharsan
#9 import-available-language-data-1632384-10.patch5.3 KBsutharsan
#4 import-available-language-data-1632384-2.patch6.56 KBwebflo
#2 import-available-language-data-1632384-1.patch6.03 KBwebflo

Comments

webflo’s picture

webflo commented
Project: Drupal core » Drupal 8 Multilingual Initiative sandbox
Version: 8.x-dev »
Component: locale.module » Code
Status: Active » Needs review

This patch is only for fetching and parsing the localization server xml.

webflo’s picture

webflo commented
StatusFileSize
new import-available-language-data-1632384-1.patch6.03 KB
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Needs work

Tests look good, pretty much covers the whole thing :) Functionality also looks good, so just some comments:

+++ b/core/modules/locale/locale.fetch.incundefined
@@ -1,9 +1,78 @@
+/*
+ * @file
+ * Fetch and parse the list of available languages from a translation server.
+ * e.g. localize.drupal.org
+ */

File comment should be on one line.

+++ b/core/modules/locale/locale.fetch.incundefined
@@ -1,9 +1,78 @@
+/**
+ * Get server information
+ */

Should have . at line end :) Mostly a problem at all other places for comments too in the patch :)

+++ b/core/modules/locale/locale.fetch.incundefined
@@ -1,9 +1,78 @@
+function locale_get_server($server) {
+  // Fetch up to date information if available
+  if (!empty($server['server_url']) && $fetch = locale_fetch_server($server['server_url'])) {
+    $server = array_merge($server, $fetch);
+  }
+  // If we have an update url this is ok, otherwise we return none
+  if (!empty($server['update_url'])) {
+    return $server;
+  }
+  else {
+    return FALSE;
+  }
+}

The locale_get.... and locale_fetch... might need to be in a namespace. Although we did move lots of stuff out of locale, it still has some different things, translation, import/export and now automation for the import is added. So some "namespacing" with the function names would be good.

+++ b/core/modules/locale/locale.fetch.incundefined
@@ -1,9 +1,78 @@
 /**
- * @todo
- * Based on l10n_update_get_server().
+ * Parses the XML of l10n server translation.
+ *

l10n server translation is not very specific. Its a language list with some language metadata. :)

webflo’s picture

webflo commented
Status: Needs work » Needs review
StatusFileSize
new import-available-language-data-1632384-2.patch6.56 KB

Thanks for you review. Fixed the comments.

webflo’s picture

webflo commented

The new namespace for this functionality is locale_translation.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Is that namespace not taken or will these fit nicely in there?

sutharsan’s picture

sutharsan commented

The only use of this namespace are two variables. That does not seam a problem to me.

  • 'locale_translation_plurals'
  • 'locale_translation_javascript'
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Ok then, we'll revisit namespacing anyway :)

sutharsan’s picture

sutharsan commented
StatusFileSize
new import-available-language-data-1632384-10.patch5.3 KB

Patch reworked to apply to 8.x without being dependent on #1627006: Collect project information for translation update.

sutharsan’s picture

sutharsan commented
StatusFileSize
new interdiff-9-10.txt1.46 KB
new import-available-language-data-1632384-10-.patch5.65 KB

Changes: Some documentation added.

sutharsan’s picture

sutharsan commented
Project: Drupal 8 Multilingual Initiative sandbox » Drupal core
Version: » 8.x-dev
Component: Code » locale.module

Changing project/component to D8 locale module

webflo’s picture

webflo commented
Category: task » feature
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

I think it looks good. We should figure out if we want to push forward with this vs. actually implementing YAML export on the server, which is also useful/proposed for the automation to be done after #1632236: Convert built-in language list to CMI. We might want to make the server return YAML first and get that deployed on l.d.o, and use our YAML parser here.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

Can we assume that YAML export in l.d.o is not gonna happen before D8? What are the next steps here once that noone is pushing for #1632236: Convert built-in language list to CMI?

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Postponed

I'd say this is lower priority compared to other issues where we actually deal with project identification and .po file downloads such as #1627006: Collect project information for translation update and #1632384: Import available language list from translation server. Our first priority is to solve downloading .po files for properly identified projects, and then if we have time and can somehow solve this, then we can update the language list from localize.drupal.org. Otherwise we'll just make the installer display all languages known locally (this list was previously synced with l.d.o), and then let our existing code set it up locally and use it. Not having project .po file downloads is the main pain. Not being able to update the locally known available language list is the last concern :)

Therefore I think we should postpone this on the other two issues.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Import available language data and translations form translation server » Import available language list form translation server

Retitled to be more clear as to what we are postponing.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Title: Import available language list form translation server » Import available language list from translation server
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Postponed » Needs work
Issue tags: -sprint

Given the above explained circumstances and this being at the low end of our priority list, I have little hope this would even happen in Drupal 8, so I don't think it makes sense to keep on a postponed state even on the Drupal 8 D8MI sprint focus list.

jair’s picture

jair commented
Issue tags: +Needs reroll
internetdevels’s picture

internetdevels commented
Issue summary: View changes
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new import_available_language_data-1632384-20.patch5.67 KB

Here's a reroll.

alansaviolobo queued 20: import_available_language_data-1632384-20.patch for re-testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented
StatusFileSize
new 1632384-32.patch5.68 KB
new interdiff_20-32.txt2.42 KB

Fixed all CS errors except for CSpell failures

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 1632384-nr-bot.txt3 KB

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.